http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31674&action=edit Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31674|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31684&action=edit Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31732&action=edit [PASSED QA] Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Owen! -- You are receiving this mail because: You are watching all bug changes.