[Bug 30718] New: Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Bug ID: 30718 Summary: Use flatpickr's altInput option everywhere Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org "Show the user a readable date (as per altFormat), but return something totally different to the server." It's actually an option we want to use for all our dates, that will reduce a lot the overhead in our controllers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135487&action=edit Bug 30718: POC - Use flatpickr's altInput -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This will be a pain to implement, but it's worth the hassle. We are basically going to remove a lot of our dt_from_string, output_pref and $KohaDates occurrences. $KohaDates will be needed for display purpose only (not in flatpickr's input). We are going to retrieve the iso-formatted date from the DB, send it to the template, and retrieve the iso-formatted date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29711 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Who's willing to test and QA this? I can spend time on providing a patch, but if we want it into 22.11 it must be pushed early in the dev release cycle! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'm happy to help testing, but it would be nice it could be broken up a bit so templates can be tested in smaller 'chunks'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #4)
I'm happy to help testing, but it would be nice it could be broken up a bit so templates can be tested in smaller 'chunks'.
I don't think it's a good idea. The flatpickr's config change is done for all the instances, so we will need to flag the instances that have been fixed to differentiate them from others (and when all fixed, remove the flag?). There is a lot of occurrences, and I think we can catch easily missing ones with `git grep` (KohaDates from tt/inc and output_pref from pl/pm), but it will be hard if only part of the job is done. Finally I think we need a moment when devs know that we did the switch, or we will never know if we need to escape using KohaDates or html. Also, I am pretty sure this change will take years if we split it into dozens of reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135487|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137516&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this patch is ready for testing, but it's hard to tell what need to be tested! Basically it's *any* date manipulation all over Koha that needs to be tested, so... lot of testing! This patch is great has it is removing 400 lines of ugly and unnecessary date manipulation. 114 files changed, 302 insertions(+), 706 deletions(-) It makes the code so cleaner! I won't benchmark but I am expecting (non-significant) perf improvements here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ha, and, this patch has bugs, for sure! Please help me find them! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 [Bug 30310] Replace Moment.js with Day.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137516|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137707&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Some places to test: 1. KohaDates is used instead of html, as we moved the formatting to the template (and remove the output_pref(dt_from_string)) call from the pl/pm) 2. Places where we retrieve from flatpickr and resent to the template (sticky due date in circ for instance) 3. REST API - I think I made some changes there as well (but maybe it is on a follow-up bug, cannot remember) 4. Flatpickr needs to be tested 5. there is as well the cataloguing plugin that is using altInput already 6. Lot of changes in the reports area (I haven't tested at all this module) 7. There is a block commented in Koha::Report that certainly needs attention -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I've gone through Acquisitions pages and found only one issue: - lateorders.pl: Can't locate object method "ymd" via package "2010-07-02" (perhaps you forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line 100 In that error "2020-07-02" is the "Estimated delivery date from:" value I was trying to filter on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137715&action=edit Bug 30718: Pass DT to filter_by_lates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #11)
- lateorders.pl: Can't locate object method "ymd" via package "2010-07-02" (perhaps you forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line 100
Fixed, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- More notes after having gone through almost everything and tested the basics: - lateorders.pl: Can't locate object method "ymd" via package "2010-07-02" (perhaps you forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line 100 - circulation.pl Template process failed: undef error - The given date (01.06.2022 11:59 PM) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205. at /kohadevbox/koha/C4/Templates.pm line 127 The above error occurred when checking out and specifying a date in the past. - overdues.pl The date in the heading is formatted incorrectly: "1 Item overdue as of 2022-07-14T13:53:00" - serials/claims.pl: "Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127" - tools/holidays.pl "Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127" I noticed this in the log for export.pl after testing a date-limited export. The export completed fine as far as I can tell. [Thu Jul 14 15:46:05.900437 2022] [cgi:error] [pid 83824] [client 172.18.0.1:62854] AH01215: DBIx::Class::Storage::DBI::_gen_sql_bind(): DateTime objects passed to search() are not supported properly (InflateColumn::DateTime formats and settings are not respected.) See ".. format a DateTime object for searching?" in DBIx::Class::Manual::FAQ. To disable this warning for good set $ENV{DBIC_DT_SEARCH_OK} to true at /kohadevbox/koha/Koha/Objects.pm line 312: /kohadevbox/koha/tools/export.pl, referer: http://127.0.0.1:8081/cgi-bin/koha/tools/export.pl - Tasks scheduler: "Failed to add Tasks" I didn't see anything in the error log that appeared to be related to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137803&action=edit Bug 30718: Fix today's date on overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137804&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137805&action=edit Bug 30718: Add missing USE KohaDates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137806&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137807&action=edit Bug 30718: Fix scheduler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #14) Thanks a lot, Owen, you are awesome! :)
More notes after having gone through almost everything and tested the basics:
- lateorders.pl: Can't locate object method "ymd" via package "2010-07-02" (perhaps you forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line 100
- circulation.pl Template process failed: undef error - The given date (01.06.2022 11:59 PM) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205. at /kohadevbox/koha/C4/Templates.pm line 127
The above error occurred when checking out and specifying a date in the past.
- overdues.pl The date in the heading is formatted incorrectly: "1 Item overdue as of 2022-07-14T13:53:00"
- serials/claims.pl: "Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127"
- tools/holidays.pl "Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127"
All fixed!
I noticed this in the log for export.pl after testing a date-limited export. The export completed fine as far as I can tell.
[Thu Jul 14 15:46:05.900437 2022] [cgi:error] [pid 83824] [client 172.18.0.1:62854] AH01215: DBIx::Class::Storage::DBI::_gen_sql_bind(): DateTime objects passed to search() are not supported properly (InflateColumn::DateTime formats and settings are not respected.) See ".. format a DateTime object for searching?" in DBIx::Class::Manual::FAQ. To disable this warning for good set $ENV{DBIC_DT_SEARCH_OK} to true at /kohadevbox/koha/Koha/Objects.pm line 312: /kohadevbox/koha/tools/export.pl, referer: http://127.0.0.1:8081/cgi-bin/koha/tools/export.pl
Also in master, should be fixed (but reported separately).
- Tasks scheduler: "Failed to add Tasks"
I didn't see anything in the error log that appeared to be related to this.
Fixed (note that time part is mandatory but the UI does not ask for it). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-ups can be squashed of course -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Owen Leonard <oleonard@myacpl.org> ---
- circulation.pl Template process failed: undef error - The given date (01.06.2022 11:59 PM) does not match the date format (iso) at
The above error occurred when checking out and specifying a date in the past.
I'm still getting this error when manually selecting a due date in the past. I now notice that the time portion of the datetime is not appearing in the input field. The same is true on the checkin and offline circulation page.
- tools/holidays.pl
There's now a little calendar icon showing above the calendar on this page.
- Tasks scheduler: "Failed to add Tasks" Fixed (note that time part is mandatory but the UI does not ask for it).
Would it make sense to update the form in this patch set to use a single field with the Flatpickr timepicker enabled? I notice also that paired date fields (start date & end date) now show an extra "X" icon after the second field, e.g. serial claims or catalog statistics. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137868&action=edit Bug 30718: Fix time display Especifically when timeformat=12h -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137869&action=edit Bug 30718: Prevent 'reset' icon to appear twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #22)
- circulation.pl Template process failed: undef error - The given date (01.06.2022 11:59 PM) does not match the date format (iso) at
The above error occurred when checking out and specifying a date in the past.
I'm still getting this error when manually selecting a due date in the past.
I now notice that the time portion of the datetime is not appearing in the input field. The same is true on the checkin and offline circulation page.
This was hiding something critical, thanks for the catch.
- tools/holidays.pl
There's now a little calendar icon showing above the calendar on this page.
Yes, we don't need it there, fixed.
- Tasks scheduler: "Failed to add Tasks" Fixed (note that time part is mandatory but the UI does not ask for it).
Would it make sense to update the form in this patch set to use a single field with the Flatpickr timepicker enabled?
I would consider that different from what we are doing here. Should be fixed separately in my opinion.
I notice also that paired date fields (start date & end date) now show an extra "X" icon after the second field, e.g. serial claims or catalog statistics.
Fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Conflicts, if you don't have time, I can give a try before Monday. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137707|0 |1 is obsolete| | Attachment #137715|0 |1 is obsolete| | Attachment #137803|0 |1 is obsolete| | Attachment #137804|0 |1 is obsolete| | Attachment #137805|0 |1 is obsolete| | Attachment #137806|0 |1 is obsolete| | Attachment #137807|0 |1 is obsolete| | Attachment #137868|0 |1 is obsolete| | Attachment #137869|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138644&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138645&action=edit Bug 30718: Pass DT to filter_by_lates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138646&action=edit Bug 30718: Fix today's date on overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138647&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138648&action=edit Bug 30718: Add missing USE KohaDates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138649&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138650&action=edit Bug 30718: Fix scheduler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138651&action=edit Bug 30718: Fix time display Especifically when timeformat=12h -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138652&action=edit Bug 30718: Prevent 'reset' icon to appear twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having a look here right now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- testing 9 commit(s) (applied to e544ff4 '45 Bug 29632: (QA follow-up) Fix COMM') Processing files before patches |========================>| 118 / 118 (100.00%) Processing files after patches |========================>| 118 / 118 (100.00%) No failures from qa tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Minor code observations: Koha/Hold.pm + $date &&= dt_from_string($date)->truncate( to => 'day' )->datetime; Obsure code clubs/clubs-add-modify.pl +my $date_start = $cgi->param('date_start') || undef; Does this || undef really serve any purpose here? Not the only occurrence btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Editing items: Should $w Price effective from be controlled by flatpickr ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. I am just globally testing a bit. But this does not provide confidence: Adding a expiration date for a new hold. The date does not get saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #38)
Minor code observations:
Koha/Hold.pm + $date &&= dt_from_string($date)->truncate( to => 'day' )->datetime; Obsure code
Obscure? It's using a basic perl operator... Prefer the verbose if version if ( $date ) { $date = dt_from_string($date)->truncate( to => 'day' )->datetime; } or the ugly ternary? $date = $date ? dt_from_string($date)->truncate( to => 'day' )->datetime : undef I don't.
clubs/clubs-add-modify.pl +my $date_start = $cgi->param('date_start') || undef; Does this || undef really serve any purpose here? Not the only occurrence btw.
I don't know, but trying to prevent regressions by keeping the exact same behaviours. (In reply to Marcel de Rooy from comment #39)
Editing items: Should $w Price effective from be controlled by flatpickr ?
Isn't it already? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Allowing future hold dates: | 77 | 51 | 0000-00-00 | 1 | CPL | NULL | NULL | NULL | NULL | NULL | | 1 | NULL | 2022-08-05 08:48:48 | NULL | NULL | 0000-00-00 | 0000-00-00 | 0 | 0 | NULL | NULL | 0 | 0 | I am getting 0000-00-00 dates in now. Three in a row . Hmm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #40)
Hmm. I am just globally testing a bit. But this does not provide confidence:
Adding a expiration date for a new hold. The date does not get saved.
It does for me, can you provide more detail maybe? /cgi-bin/koha/reserve/request.pl?biblionumber=117 search edna select a date in "Hold expires on date:" place hold => Date is in the expiration column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #43)
(In reply to Marcel de Rooy from comment #40)
Hmm. I am just globally testing a bit. But this does not provide confidence:
Adding a expiration date for a new hold. The date does not get saved.
It does for me, can you provide more detail maybe?
/cgi-bin/koha/reserve/request.pl?biblionumber=117 search edna select a date in "Hold expires on date:" place hold => Date is in the expiration column
I am testing now under dd/mm/yy. Could that be the cause ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No with mm/dd/yy I still have a new hold without two dates (hold start and end date entered). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hey. When I switch to yy-mm-dd only THEN the hold dates are saved ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- | 79 | 51 | 2022-08-08 | 1 | CPL | NULL | NULL | NULL | NULL | NULL | | 1 | NULL | 2022-08-05 08:56:43 | NULL | NULL | 2022-08-15 | 2022-08-15 | 0 | 0 | NULL | NULL | 0 | 0 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Well I give up. Code looks good, nice improvement. But it does not work for me on holds. That is not providing confidence. Have some more people test it. Try adding a hold with start and end date in various dateformat settings. Will not set FQA but would be inclined to.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138658&action=edit Bug 30718: Apply flatpickr changes to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138659&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #48)
Well I give up. Code looks good, nice improvement. But it does not work for me on holds. That is not providing confidence. Have some more people test it. Try adding a hold with start and end date in various dateformat settings.
Will not set FQA but would be inclined to..
The flatpick's options hadn't been updated at the OPAC. Please try with the last two patches applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138644|0 |1 is obsolete| | --- Comment #52 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138748&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138645|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138749&action=edit Bug 30718: Pass DT to filter_by_lates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138646|0 |1 is obsolete| | --- Comment #54 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138750&action=edit Bug 30718: Fix today's date on overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138647|0 |1 is obsolete| | --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138751&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138648|0 |1 is obsolete| | --- Comment #56 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138752&action=edit Bug 30718: Add missing USE KohaDates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138649|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138753&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138650|0 |1 is obsolete| | --- Comment #58 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138754&action=edit Bug 30718: Fix scheduler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138651|0 |1 is obsolete| | --- Comment #59 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138755&action=edit Bug 30718: Fix time display Especifically when timeformat=12h -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138652|0 |1 is obsolete| | --- Comment #60 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138756&action=edit Bug 30718: Prevent 'reset' icon to appear twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138658|0 |1 is obsolete| | --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138757&action=edit Bug 30718: Apply flatpickr changes to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138659|0 |1 is obsolete| | --- Comment #62 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138758&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #63 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Another rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #64 from Victor Grousset/tuxayo <victor@tuxayo.net> --- tested: - checkout with date in the past - hold expiration date with all formats, staff and OPAC - making date changes in patron details - create a report and schedule it - issue found: the picker doesn't let pick today as a date - check-in with custom date - logs view (date from and date to) --- (In reply to Marcel de Rooy from comment #48)
Try adding a hold with start and end date in various dateformat settings.
What is hold start date? The reservedate column, is there an input for that? I my testing, reservedate along with expirationdate and patron_expiration_date always have values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #64)
tested: - checkout with date in the past - hold expiration date with all formats, staff and OPAC - making date changes in patron details - create a report and schedule it - issue found: the picker doesn't let pick today as a date
This is the behaviour in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #66 from Victor Grousset/tuxayo <victor@tuxayo.net> --- tested: - order: field "d - Date acquired" (dateaccessioned) - receive shipment: shipmentdate field - receive order: datereceived field - finish receiving: Shipment date and Billing date - Budgets administration > edit budget > start and end dates - patron categories: Enrollment period - batch check out due date - circulation: overdues: from and to dates - holds to pull: start and end dates - renew: Renewal due date - issue found, with the patches, I don't get the "Item renewed" message box. It doesn't renew, I just get back to the same page. Without inputting a date, it works. logs: Invalid date passed to AddRenewal. at /kohadevbox/koha/circ/renew.pl line 101. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138879&action=edit Bug 30718: Fix renewal with due date This was a test added by the following commit: commit 99eccc18ed4a21fa416a3d61fed3f70825dc2203 Date: Thu Jun 16 10:10:09 2011 +0100 Bug 5549 : Handle datetimes on return It's no longer needed now, we can pass a DateTime or an ISO-formatted date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #66)
- renew: Renewal due date - issue found, with the patches, I don't get the "Item renewed" message box. It doesn't renew, I just get back to the same page. Without inputting a date, it works. logs: Invalid date passed to AddRenewal. at /kohadevbox/koha/circ/renew.pl line 101.
Fixed in the last commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #69 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Jonathan, it works :) tested: - renew: Renewal due date - check in: custom return date - club: start and end date - Reports Cash > register statistics: from and to dates - Serials > Check expiration: Expiring before date - serials > claims: from and to filters - issue found: with the patches, any date range gives empty results. While without, it works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138980&action=edit Bug 30588: Fix serial claims filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #71 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139033&action=edit Bug 30718: Fix serial claims filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #72 from Victor Grousset/tuxayo <victor@tuxayo.net> --- fixed ticket number for patch "Fix serial claims filters" tested: - serials > claims: from and to filters - serials search: Expires before field in only-search-form view and result view (search form on the left) - serials: new subscription: First issue publication date + Subscription start date + Subscription end date - suggestion list: "Suggestion information" the 3 date filters - Tools > Tags: date from and to continuing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138748|0 |1 is obsolete| | --- Comment #73 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139073&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138749|0 |1 is obsolete| | --- Comment #74 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139074&action=edit Bug 30718: Pass DT to filter_by_lates Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138750|0 |1 is obsolete| | --- Comment #75 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139075&action=edit Bug 30718: Fix today's date on overdue Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138751|0 |1 is obsolete| | --- Comment #76 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139076&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138752|0 |1 is obsolete| | --- Comment #77 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139077&action=edit Bug 30718: Add missing USE KohaDates Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138753|0 |1 is obsolete| | --- Comment #78 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139078&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138754|0 |1 is obsolete| | --- Comment #79 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139079&action=edit Bug 30718: Fix scheduler Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138755|0 |1 is obsolete| | --- Comment #80 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139080&action=edit Bug 30718: Fix time display Especifically when timeformat=12h Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138756|0 |1 is obsolete| | --- Comment #81 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139081&action=edit Bug 30718: Prevent 'reset' icon to appear twice Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138757|0 |1 is obsolete| | --- Comment #82 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139082&action=edit Bug 30718: Apply flatpickr changes to OPAC Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138758|0 |1 is obsolete| | --- Comment #83 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139083&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138879|0 |1 is obsolete| | --- Comment #84 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139084&action=edit Bug 30718: Fix renewal with due date This was a test added by the following commit: commit 99eccc18ed4a21fa416a3d61fed3f70825dc2203 Date: Thu Jun 16 10:10:09 2011 +0100 Bug 5549 : Handle datetimes on return It's no longer needed now, we can pass a DateTime or an ISO-formatted date Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139033|0 |1 is obsolete| | --- Comment #85 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 139085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139085&action=edit Bug 30718: Fix serial claims filters https://bugs.koha-community.org/show_bug.cgi?id=30718 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #86 from Victor Grousset/tuxayo <victor@tuxayo.net> --- tested: (continuation of previous comments) - tools > news: new entry: Publication date and Expiration date - calendar: add new holiday: To date field - patron import: Registration date, Date of birth, Expiry date - inventory: "Set inventory date to" value isn't honored even without the patches. datelastseen is always set to today. - inventory: "Last inventory date" filter - opac: Your personal details: date of birth - offline circulation, can't test because of bug 31358 That should be it, after going through all the changed pages (listing the .tt from the patches) to try to find all the date inputs there and checking that they behave correctly, it looks good to move on :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #87 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA scheduled for 19-08-22 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #88 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Resuming QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #89 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Fixed small rebase conflict on first patch for opac-reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #90 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still no QA tools complaints for 119 files now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #91 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #85)
Created attachment 139085 [details] [review] Bug 30718: Fix serial claims filters
https://bugs.koha-community.org/show_bug.cgi?id=30718 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
This patch does: - var beginDate = Date_from_syspref($("#from").val()).getTime(); - var endDate = Date_from_syspref($("#to").val()).getTime(); + var beginDate = new Date($("#from").val()).getTime(); + var endDate = new Date($("#to").val()).getTime(); Still seeing in its context: // We make a JS Date Object, according to the locale var pdate = Date_from_syspref($(this).text()).getTime(); And it seems the only real remains of this function. So it probably should be changed too. Not tested however. While finishing up, leaving it here as TODO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #92 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep Date_from_syspref koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc: original_date = Date_from_syspref( original_date ).getTime(); koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt: var pdate = Date_from_syspref($(this).text()).getTime(); koha-tmpl/intranet-tmpl/prog/js/calendar.js:function Date_from_syspref(dstring) { koha-tmpl/intranet-tmpl/prog/js/calendar.js: alert("Date_from_syspref(" + dstring + ") splits to:\n" + dateX.join("\n")); koha-tmpl/intranet-tmpl/prog/js/calendar.js: var datetime = Date_from_syspref(date); koha-tmpl/intranet-tmpl/prog/js/calendar.js: var from = Date_from_syspref($(params).val()); koha-tmpl/intranet-tmpl/prog/js/calendar.js: var to = Date_from_syspref(value); koha-tmpl/intranet-tmpl/prog/js/calendar.js: var from = Date_from_syspref($(params).val()); koha-tmpl/intranet-tmpl/prog/js/calendar.js: var to = Date_from_syspref(value); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139073|0 |1 is obsolete| | --- Comment #93 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139453&action=edit Bug 30718: Use flatpickr's altInput The idea rely on the KohaDates TT plugin for the date formatting. We should not have any output_pref calls in pl or pm (there are some exceptions, for ILSDI for instance). Also flatpickr will deal with the places where dates are inputed. We will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and the controller will receive the same value, no need to additional conversion. Note that DBIC has the capability to auto-deflate DateTime objects, which makes things way easier. We can either pass the value we receive from the controller, or pass a DT object to our methods. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139074|0 |1 is obsolete| | --- Comment #94 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139454&action=edit Bug 30718: Pass DT to filter_by_lates Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139075|0 |1 is obsolete| | --- Comment #95 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139455&action=edit Bug 30718: Fix today's date on overdue Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139076|0 |1 is obsolete| | --- Comment #96 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139456&action=edit Bug 30718: Fix serials/showpredictionpattern.pl Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl line 100 eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139077|0 |1 is obsolete| | --- Comment #97 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139457&action=edit Bug 30718: Add missing USE KohaDates Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139078|0 |1 is obsolete| | --- Comment #98 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139458&action=edit Bug 30718: Fix holidays Template process failed: undef error - The given date (07/18/2022) does not match the date format (iso) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139079|0 |1 is obsolete| | --- Comment #99 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139459&action=edit Bug 30718: Fix scheduler Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139080|0 |1 is obsolete| | --- Comment #100 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139460&action=edit Bug 30718: Fix time display Especifically when timeformat=12h Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139081|0 |1 is obsolete| | --- Comment #101 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139461&action=edit Bug 30718: Prevent 'reset' icon to appear twice Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139082|0 |1 is obsolete| | --- Comment #102 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139462&action=edit Bug 30718: Apply flatpickr changes to OPAC Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139083|0 |1 is obsolete| | --- Comment #103 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139463&action=edit Bug 30718: Fix dates display at the OPAC Found dateofbirth so far, do we have others? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139084|0 |1 is obsolete| | --- Comment #104 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139464&action=edit Bug 30718: Fix renewal with due date This was a test added by the following commit: commit 99eccc18ed4a21fa416a3d61fed3f70825dc2203 Date: Thu Jun 16 10:10:09 2011 +0100 Bug 5549 : Handle datetimes on return It's no longer needed now, we can pass a DateTime or an ISO-formatted date Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139085|0 |1 is obsolete| | --- Comment #105 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139465&action=edit Bug 30718: Fix serial claims filters https://bugs.koha-community.org/show_bug.cgi?id=30718 Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #106 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139466&action=edit Bug 30718: (QA follow-up) Apply prevent duplication on OPAC too See former intranet side patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #107 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139467&action=edit Bug 30718: (QA follow-up) KohaDates filter on inputs Found another one on a visible input. Replaced with html filter. koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt: <input type="text" class="enrolmentperioddate" name="enrolmentperioddate" id="enrolmentperioddate" value="[% category.enrolmentperioddate | $KohaDates %]" /> But we also have a few hidden ones. First verified that cleanborrowers did not work anymore with expirydate. Fixed it with passing iso dateformat to resolve. intranet-tmpl/prog/en/modules/acqui/parcels.tt: <input type="hidden" name="shipmentdate" value="[% shipmentdate | $KohaDates %]" /> intranet-tmpl/prog/en/modules/serials/subscription-add.tt: <input type="hidden" id="acqui_date" name="firstacquidate" value="[% firstacquidate | $KohaDates %]"/> intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt: <input type="hidden" name="new_hard_due_date" value="[% new_hard_due_date | $KohaDates %]" /> intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="not_borrowed_since" value="[% not_borrowed_since | $KohaDates %]" /> intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="last_issue_date" value="[% last_issue_date | $KohaDates %]" /> intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="borrower_dateexpiry" value="[% borrower_dateexpiry | $KohaDates %]" /> intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="borrower_lastseen" value="[% borrower_lastseen | $KohaDates %]" /> Test plan: Try cleanborrowers with expiry date. cd koha-tmpl; git grep "<input.*\$KohaDates" | grep -v iso Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #108 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139468&action=edit Bug 30718: (QA follow-up) Remove double use KohaDates Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #109 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ok Tomas, go ahead and push it. We will find the remaining things. Victor did a great job in testing too. Thx Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does this touch any of the coding guidelines or should we have a new one for how we want things to be done? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #111 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #112 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139490&action=edit Bug 30718: Fix imports Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *ping* (In reply to Katrin Fischer from comment #110)
Does this touch any of the coding guidelines or should we have a new one for how we want things to be done?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #114 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139605&action=edit Bug 30718: (follow-up) index_records is called more times than we thought Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 [Bug 31437] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #115 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #114)
Created attachment 139605 [details] [review] Bug 30718: (follow-up) index_records is called more times than we thought
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Is there any connection with this report ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #116 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #115)
(In reply to Tomás Cohen Arazi from comment #114)
Created attachment 139605 [details] [review] [review] Bug 30718: (follow-up) index_records is called more times than we thought
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Is there any connection with this report ?
I couldn't find the reason, but git bisect Matthews this bug as responsible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #117 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #118 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (This is so AWESOME!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #119 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143175&action=edit Bug 30718: Fix curbside pickups No slots are displayed without this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_11_candidate | --- Comment #120 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 [Bug 32111] Cannot schedule a pickup at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33414 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 [Bug 33414] Dates displayed in ISO format in orders by fund -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 [Bug 33821] OPAC flatpickr no longer allows for direct input of date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 [Bug 33901] Only one issue shown in Test prediction pattern -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34231 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34117 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 [Bug 34117] Duplicate patron sets dateenrolled incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 [Bug 35559] Can't change the pickup date of holds on the last day of expiration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org