[Bug 32984] New: The edifact message that receives an item should be linked on the 'Acquisition details' tab on catalogue details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Bug ID: 32984 Summary: The edifact message that receives an item should be linked on the 'Acquisition details' tab on catalogue details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146739&action=edit Bug 32984: Add link to EDI invoice to "Invoice" column if there is one Test Plan: 1) Find or create an item invoiced via an EDI INVOICE message 2) Ensure you have the edi_manage subpermission 3) View catalogue/detail.pl, not the invoice link in the invoice column 4) Apply this patch 5) Restart all the things! 6) Reload catalogue/detail.pl 7) Note the new "(EDI invoice)" link in the column for the item 8) Verify the link does not show if you do not have the edi_manage subpermission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The edifact message that |The EDIFACT message that |receives an item should be |receives an item should be |linked on the 'Acquisition |linked on the 'Acquisition |details' tab on catalogue |details' tab on catalogue |details page |details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146739|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155456&action=edit Bug 32984: Add link to EDI invoice to "Invoice" column if there is one Test Plan: 1) Find or create an item invoiced via an EDI INVOICE message 2) Ensure you have the edi_manage subpermission 3) View catalogue/detail.pl, not the invoice link in the invoice column 4) Apply this patch 5) Restart all the things! 6) Reload catalogue/detail.pl 7) Note the new "(EDI invoice)" link in the column for the item 8) Verify the link does not show if you do not have the edi_manage subpermission Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch, tested and signed off by a customer of ptfs-europe. I'm opting to QA as it's useful addition without risk of regressions. QA scripts are happy and code is simple and working Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155457&action=edit Bug 32984: (QA follow-up) Update to respect EDIFACT preference Since the first submission of this patch we have introduced a system preference to enable/disable edifact in it's entirety. This patch adds the check for this preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk --- Comment #5 from Jeremy Evans <jeremy.evans@ukhsa.gov.uk> --- This is working well but it would be easier to read on the display if the EDI invoice link can start on a new line underneath the Invoice number. At the moment it makes the Invoice number harder to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853 [Bug 34853] Move EDI link to new line in invoice column of acquisition details display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up to take care of comment above added to new bug linked. Bug 34853 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe Ltd* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org