[Bug 14056] New: Small punctuation error in description for deleting a holiday
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Bug ID: 14056 Summary: Small punctuation error in description for deleting a holiday Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org When deleting a holiday in the calendar, the description for 'Delete the exceptions within a range" reads --> "This will delete the exceptions inside a given range. Be careful about your scope range if it is oversized you could slow down Koha." Small punctuation error here - should have a hyphen ie ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 38470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38470&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a hyphen into the description so that it makes sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a hyphen and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Severity|enhancement |trivial --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I'm not part of the grammar police, but it seems to me that hyphen is not the most natural and plain way of expressing this. Though, I definitely agree there needs a tweak somehow. Perhaps: Be careful about your scope range; if it is oversized, you could slow down Koha. instead? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38470|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 38581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38581&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38581|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38583&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38583|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38613&action=edit [PASSED QA] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org