http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Patch applied cleanly but date is still not sorting correctly. Will leave as Needs signoff in case I'm testing it wrong -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37720|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37786&action=edit Bug 13982 - Checkouts table not sorting on correct column The "Date Due" column for checkouts is using the column index 1 to sort by. This column is the one that is used for grouping items into today's checkouts and previous checkouts. This is definitely not the column that should be used. Instead, we should be using column index 2, which contains the raw unformatted due date. Revised Test Plan: 1) Find a patron with no checkouts 2) Check out something as due the beginning on the month. 3) Check out something as due the end of the month. 4) Check out something due tomorrow (hopefully not end of month) -- so you should have 2015-04-01, 2015-04-30, and 2015-04-14 (for example) 5) Attempt to sort by due date -- Note the sorting is incorrect 6) Apply this patch 7) Clear your browser cache 8) Reload the page 9) Attempt to sort by due date again -- Note the sorting works correctly this time 10) Verify there are no regressions with bug 13908 -- this will require finding a patron with many checkouts, playing with the Circulation system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder, and understanding what the four different cases mean with respect to actually manually sorting the 'Due Date' column. NOTE: I did not do step 10, Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37786|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38140&action=edit [PASSED QA] Bug 13982 - Checkouts table not sorting on correct column The "Date Due" column for checkouts is using the column index 1 to sort by. This column is the one that is used for grouping items into today's checkouts and previous checkouts. This is definitely not the column that should be used. Instead, we should be using column index 2, which contains the raw unformatted due date. Revised Test Plan: 1) Find a patron with no checkouts 2) Check out something as due the beginning on the month. 3) Check out something as due the end of the month. 4) Check out something due tomorrow (hopefully not end of month) -- so you should have 2015-04-01, 2015-04-30, and 2015-04-14 (for example) 5) Attempt to sort by due date -- Note the sorting is incorrect 6) Apply this patch 7) Clear your browser cache 8) Reload the page 9) Attempt to sort by due date again -- Note the sorting works correctly this time 10) Verify there are no regressions with bug 13908 -- this will require finding a patron with many checkouts, playing with the Circulation system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder, and understanding what the four different cases mean with respect to actually manually sorting the 'Due Date' column. NOTE: I did not do step 10, Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.