[Bug 17221] New: orphan comma in shelf browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Bug ID: 17221 Summary: orphan comma in shelf browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org Created attachment 54997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997&action=edit screenshot of bug Example screenshot attached, here's the bib record in our catalog: https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729&shelfbrowse_itemnumber=34420#holdings Basically, since starting_homebranch is null in the template file, nothing is printed out, but the next IF condition wrongly assumes that the first must have been true and prints out a comma before it's text string. Steps to recreate: - in settings, set ShelfBrowserUsesHomeBranch to "Don't Use" - set ShelfBrowserUsesLocation to "Use" - visit an item, click the "Browse shelf" link in the Holdings' tab's Call Number column - note the extraneous comma in the <h5> tag that appears Patch coming shortly, it appears that simply adding an additional condition around the comma itself should resolve this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 54998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54998&action=edit patch patch anticipates same problem with collection code in list, too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- If you have ShelfBrowserUsesCcode, ShelfBrowserUsesHomeBranch, and ShelfBrowserUsesLocation all set to 'Use," but you are browsing an item which doesn't have a shelving location there are extra commas: " Browsing Athens Shelves , , Collection code: Juvenile fiction " I wonder if that scenario can be handled as well? By the way, please include a test plan in your commit messages. And if you would like to be credited by name in Koha's release notes, about page, etc., configure git with your real name so it appears in the patch. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- Thanks for the feedback Owen, I'll take another look & develop a better testing plan. It's difficult because there are so many permutations of settings and then fields that could be empty on the item records but that's all the more reason to have a well-defined plan. I want to be credited to my GitHub username (phette23) so the lack of my real name in the commit notes is intentional. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think you can still get credited if it's not a direct match between your commit message and your user name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ephetteplace@cca.edu |katrin.fischer@bsz-bw.de Summary|orphan comma in shelf |Orphan comma in shelf |browser |browser -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97267&action=edit Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97268&action=edit Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97267|0 |1 is obsolete| | Attachment #97268|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98830&action=edit Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98831&action=edit Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98830|0 |1 is obsolete| | Attachment #98831|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99188&action=edit Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99189&action=edit Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org