[Bug 24110] New: Template vars are incorrectly html filtered when dumped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bug ID: 24110 Summary: Template vars are incorrectly html filtered when dumped Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 13618 Referring to DumpTemplateVarsIntranet and DumpTemplateVarsOpac Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95809&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95809|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98962&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98962|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99135&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting complicate to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org