[Bug 18749] New: xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Bug ID: 18749 Summary: xt/sample notices fails with "No sample notice to delete" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: ldjamison@marywood.edu QA Contact: gmcharlt@gmail.com Testing xt/sample_notices.t results in 11 test failures of "No sample notice to delete". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64086&action=edit Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64086|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64180&action=edit [SIGNED-OFF] Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64180|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64262&action=edit Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on onboarding feature which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org