https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 55886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55886&action=edit Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Juliette <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 56193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56193&action=edit Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56193|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56541&action=edit Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette <juliette.levast@iepg.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed in 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.