[Bug 11904] New: Proposal for a uniform way to send messages to user interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bug ID: 11904 Summary: Proposal for a uniform way to send messages to user interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org I find quite horrible that for sending a message to user interface we have to do something like that: $template->param(there_was_an_error_during_checkout => 1); then in template: [% IF there_was_an_error_during_checkout = 1 %] <div>There was an error during checkout</div> [% END %] or even worse, having to add a parameter in the URL we want to redirect to. So here is a proposal for a uniform way to send messages to user interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25910&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25911&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25912&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Note: These patches don't introduce the new template include file anywhere. It will requires additional patches to make it work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- I've been unable to test this because I cannot apply the patches for 11848, but I think this is a most excellent idea! It reminds me of stash for Perl Catalyst. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8044, 11848 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Kyle M Hall from comment #5)
I've been unable to test this because I cannot apply the patches for 11848, but I think this is a most excellent idea! It reminds me of stash for Perl Catalyst.
Did you apply the patches for 8044 first ? I just rebased them on master, so they all apply nicely if you apply them in this order: 8044, 11848, 11904. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Why doesn't this work with the existing two types of message box styles, <div class="dialog message"> and <div class="dialog alert"> ? Following the test plan the message I get is unstyled, wrapped in this: <div class="messages ok"> Is this new system designed to work with a greater number/different kind of messages? What can we do to keep the styling consistent? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> ---
Why doesn't this work with the existing two types of message box styles, <div class="dialog message"> and <div class="dialog alert"> ? Because those two divs haven't the same width and I wanted all message boxes to have the same width (and I didn't want to change existing rules to avoid breaking things)
Following the test plan the message I get is unstyled If Koha is in English, did you try to clean all possible caches (http server, browser, ...) ? I had to hit Ctrl-F5 many times during development ;)
Is this new system designed to work with a greater number/different kind of messages? What can we do to keep the styling consistent? I think we can keep "dialog" for message boxes that asks something to the user. And use "messages" for all others message boxes. These two kind of message boxes serve different purposes. Is there a real need to keep styling consistent between them?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25910|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27940&action=edit Bug 11904: New module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25911|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27941&action=edit Bug 11904: Unit tests for Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25912|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27942&action=edit Bug 11904: Example usage of new module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Julian, message is always in english, tried with fr-FR and es-ES, both translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- By "both translated", you mean you have translated the string in fr-FR-messages.po and es-ES-messages.po ? I just retried, applying patches on current master, and the translation works for me. Can you look at the log file ? Maybe there's a clue in it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Julian Maurice from comment #13)
Can you look at the log file ? Maybe there's a clue in it.
Julian, tested and works well. Test pass and no koha-qa errors. (was a problem on my side) But... you are touching some opac prog files As we are on PROG/CCSR deprecation, and this is a new feature, those will never be included. Could you reset those files? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27940|0 |1 is obsolete| | Attachment #27941|0 |1 is obsolete| | Attachment #27942|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29545&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29546&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29547&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #14)
But... you are touching some opac prog files As we are on PROG/CCSR deprecation, and this is a new feature, those will never be included.
Could you reset those files?
Done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29545|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29552&action=edit [SIGNED-OFF] Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Originally there was a conflict on bootstrap less/opac.less and css/opac.css, not now, but can't access git at this moment. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29546|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29553&action=edit [SIGNED-OFF] Bug 11904: Unit tests for Koha::Messages Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29547|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29554&action=edit [SIGNED-OFF] Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bugs 8044 and 11484 already in master Tested using es-ES, works as described. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Besides that this patch does not apply, could you, Julian, further explain the reason why these patches touch the css and less files? Is the third example patch meant for a push to mainstream, or just as a test file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29552|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30579&action=edit Bug 11904: New module Koha::Messages Rebased on master Reintroduce bootstrap/less/opac.less and bootstrap/css/opac.css that where removed by a previous rebase -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29553|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30580&action=edit Bug 11904: Unit tests for Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29554|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30581&action=edit Bug 11904: Example usage of new module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> ---
(In reply to M. de Rooy from comment #22) Besides that this patch does not apply, could you, Julian, further explain the reason why these patches touch the css and less files? If you mean "why they touch both instead of just one ?", it's because I recompiled the less file I modified and included the result of this compilation in the patch. Is this a problem ?
Is the third example patch meant for a push to mainstream, or just as a test file? I submitted this patch only to demonstrate how to use the new module, so this is just a test file. I think it can be pushed to master, but it should not block the other patches to pass.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bug 11904 depends on bug 8044, which changed state. Bug 8044 Summary: Localization for Perl scripts and modules http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Please put the css files (because they are minified) in a seperate patch, so the person testing, can skip and rebuild them easily. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30579|0 |1 is obsolete| | --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38522&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30580|0 |1 is obsolete| | --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38523&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30581|0 |1 is obsolete| | --- Comment #30 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38524&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from M. Tompsett <mtompset@hotmail.com> --- Hopefully this rebase is correct. One less "Patch does not apply". YAY! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from M. Tompsett <mtompset@hotmail.com> --- There are a couple of things that I just don't have the time to check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38522|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40960&action=edit Bug 11904: New module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38523|0 |1 is obsolete| | --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40961&action=edit Bug 11904: Unit tests for Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38524|0 |1 is obsolete| | --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40962&action=edit Bug 11904: Example usage of new module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Sorry, this doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org