[Bug 24462] New: Adjust K::A::Invoice API mapping to voted RFC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Bug ID: 24462 Summary: Adjust K::A::Invoice API mapping to voted RFC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com Now it has been voted, it needs to be adjusted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |18731 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | URL| |https://wiki.koha-community | |.org/wiki/Acquisitions_invo | |ices_endpoint_RFC Status|NEW |Needs Signoff Blocks| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97624&action=edit Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |td-koha-bugs@agogme.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97624|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 98277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98277&action=edit Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Bug 24462 depends on bug 18731, which changed state. Bug 18731 Summary: Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98277|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98616&action=edit Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe I am missing something, but the invoice API doesn't seem to show on api.koha-community.org. I thought it previously did, but not sure now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Maybe I am missing something, but the invoice API doesn't seem to show on api.koha-community.org. I thought it previously did, but not sure now.
There isn't an invoices API. But they can be embedded on orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #7)
(In reply to Katrin Fischer from comment #6)
Maybe I am missing something, but the invoice API doesn't seem to show on api.koha-community.org. I thought it previously did, but not sure now.
There isn't an invoices API. But they can be embedded on orders.
Thanks, I'll file some bugs soon. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org