[Bug 30744] New: Non-public note is visible in OPAC in Title Notes tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Bug ID: 30744 Summary: Non-public note is visible in OPAC in Title Notes tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org To reproduce: 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I haven't verified yet but that's interesting... Ah because of this sucker: my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour, opac => 1 }); That function should have a "record" parameter. It would solve the problem (and improve efficiency by reducing the number of unnecessary database calls). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #1)
I haven't verified yet but that's interesting...
Ah because of this sucker:
my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour, opac => 1 });
That function should have a "record" parameter. It would solve the problem (and improve efficiency by reducing the number of unnecessary database calls).
In fact, this could be a class method rather than an object method... for loops (like basket.pl and opac-basket.pl) that could add up... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |29871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 [Bug 30848] Introduce Koha::Filter::AuthorizedValues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135339&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha@catalyst.net.nz |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We had customers starting to notice this, so I've taken a pragmatic approach here for now.. I think this all needs a little more thought as to what level it should all sit at as fetching and processing the MARC data twice is a bit silly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135339|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135354&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #4)
We had customers starting to notice this, so I've taken a pragmatic approach here for now..
I think this all needs a little more thought as to what level it should all sit at as fetching and processing the MARC data twice is a bit silly.
I don't like it but I do see the pragmatism... Yet, if we do this, I don't think we'll ever fix the performance of get_marc_notes() :/. Would a compromise be to add a "record" parameter to "get_marc_notes", and just update the call in opac/opac-detail.pl for now (we could open other tickets for the other Perl scripts)? That would fix Bug 30744 without duplicating processing and with less code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I was actually just seeing this as a stepping stone.. I intend to work on bug 29652 and bug 29697 next and as part of those I'm thinking we cache filtered records much lower in the stack so we're not passing around a record but rather any method we call already has a shared copy to refer to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135354|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135365&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135365|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 135415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135415&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |nonpublic notes (583$x) in | |the OPAC. Before this, if | |the OPAC visibility setting | |in the framework for 583$x | |was set not to show, it was | |still showing. CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker): 1. I followed the steps in comment #1 2. After applying the patch, I refreshed the OPAC page and the nonpublic note was no longer visible. 3. I changed the framework so 583$x should be visible in the OPAC, and this works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a little worried that we won't be able to backport this looking at the dependency tree. Would it be possible to create a simple fix for the older versions in addition to this? I wonder if it might have been better to deal with expanding authorised values separately? Detail page explodes: Can't locate object method "search" via package "Koha::ClassSources" (perhaps you forgot to load "Koha::ClassSources"?) at /kohadevbox/koha/C4/Biblio.pm line 1510 Tests fail: t/db_dependent/Koha/Biblio.t .. 13/21 # Failed test 'Authorised value is correctly parsed to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 719. # got: 'CODE' # expected: 'Description should show' # Failed test 'Authorised value is correctly parsed for OPAC to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 727. # got: 'CODE' # expected: 'Description should show OPAC' # Looks like you failed 2 tests of 14. t/db_dependent/Koha/Biblio.t .. 15/21 # Failed test 'get_marc_notes() MARC21 tests' # at t/db_dependent/Koha/Biblio.t line 736. t/db_dependent/Koha/Biblio.t .. 21/21 # Looks like you failed 1 test of 21. t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests Test Summary Report ------------------- t/db_dependent/Koha/Biblio.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 15 Non-zero exit status: 1 Files=1, Tests=21, 14 wallclock secs ( 0.05 usr 0.01 sys + 11.36 cusr 1.68 csys = 13.10 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135415|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135757&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135758&action=edit Bug 30744: Optionally allow passing record to prevent refetch This patch adds the option to pass the marcrecord into the call to prevent the extra DB fetch of the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- * Minor rebase for change of filter name in bug 30848 (to fix Katrins issue) * Minor follow-up to allow for David's request that we can pass a record along rather than refetching it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can create a backportable version of this easily enough too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 [Bug 30918] Non-public note is visible in OPAC in Title Notes tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30918 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 [Bug 30918] Non-public note is visible in OPAC in Title Notes tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29871 |30918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 [Bug 30918] Non-public note is visible in OPAC in Title Notes tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135757|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135762&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Non-public note is visible |Use RecordProcessor in |in OPAC in Title Notes tab |get_marc_notes to ensure | |non-public notes do not | |leak -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, after discussing with Tomas, I've split the bug.. the simple quick fix can now be found in bug 30918 and the work here can now be seen as the next steps to reduce the chance of leaking data in other displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #18 from David Nind <david@davidnind.com> --- What's required to test this, since the quick fix is in another bug? Or is more work still required? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Moved the original bugfix to it's own bug and changed this to an architectural one. I'm still working through this tree at the moment really so perhaps not worth testing. If you were to test, it's basically to confirm that there are no user facing changes when this bug is applied atop bug 30198 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the display of | release notes|nonpublic notes (583$x) in | |the OPAC. Before this, if | |the OPAC visibility setting | |in the framework for 583$x | |was set not to show, it was | |still showing. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #20 from David Nind <david@davidnind.com> --- Thanks Martin. I'll leave for a bit and come back to this one later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is something wrong in the design here. I really don't think it's correct to pass the marc to Koha::Biblio->get_marc_notes I feel like we need a Koha::MARC class that would have the 'get_notes' method. Koha::Biblio->get_marc_notes fetches the marc and call it If you have a marc already you could call it directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #21)
There is something wrong in the design here. I really don't think it's correct to pass the marc to Koha::Biblio->get_marc_notes
I feel like we need a Koha::MARC class that would have the 'get_notes' method.
Koha::Biblio->get_marc_notes fetches the marc and call it If you have a marc already you could call it directly.
We allow for optionally passing the marc (at Davids request)... but yes, I generally agree.. there's a bug 'move get_marc_* methods to Koha::Biblio::Metadata.. which Tomas raised and I've been trying to think of how to achieve.. this is one of the stepping stones towards that end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136783&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate, | |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|katrin.fischer@bsz-bw.de |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136783|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136793&action=edit Bug 30744: Use RecordProcessor in get_marc_notes This patch utilises RecordProcessor to filter the MARC::Record for the right interface prior to constructing the marc notes array. We also remove the use of C4::XSLT for replacing AV values in the MARC fields in preference to using the RecordProcessor filter. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- @RMAints please backport this bugs. If they don't apply we'll provide version-specific patches. But please try ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #28 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Bug 30744 depends on bug 30848, which changed state. Bug 30848 Summary: Introduce Koha::Filter::ExpandCodedFields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Bug 30744 depends on bug 30918, which changed state. Bug 30918 Summary: Non-public note is visible in OPAC in Title Notes tab https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Can't backport a dependency to 21.05.x so can't backport this. Send help to Bug 30918 if this one (30744) is really needed. (In reply to Martin Renvoize from comment #15)
I can create a backportable version of this easily enough too
That's another solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Last month to get an opportunity to have this backported to 21.05.x if that is still needed and if someone can make a patch for 21.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 [Bug 33214] Make sure cache is cleared properly (30744 follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33214 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 [Bug 33214] Make sure cache is cleared properly (30744 follow-up) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org