[Bug 12976] New: Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Bug ID: 12976 Summary: Refactor VAT and price calculation - invoice page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 12969 introduces a subroutine to centralize the VAT and price calculation. The invoice page should use it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31812&action=edit Bug 12976: Refactor VAT and price calculation - invoice page Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12969 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31812|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31823&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31823|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31880&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31880|0 |1 is obsolete| | --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31983&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl I've applied the patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) I've tested setting pref currencyformat either on FR or US. As required, I've seen on invoice.pl: CONF I 0-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 ------------------ CONF II 1-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 ------------------ CONF III 1-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 ------------------- CONF IV 0-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 ------------------- I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by bug 12969 currently not applying. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- More correctly: Blocked by bug 12896 currently not applying. :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33573&action=edit Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33612&action=edit Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33612|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33613&action=edit Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13001 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I see the dependencies correctly, this should be next - but it doesn't apply: Jonathan, can you check what's missing? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12976: Use the centralize VAT and prices calculation - invoice.pl fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12976: Use the centralize VAT and prices calculation - invoice.pl The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12976-Use-the-centralize-VAT-and-prices-calcul-H4QMVv.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31983|0 |1 is obsolete| | Attachment #33573|0 |1 is obsolete| | Attachment #33613|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34933&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34934&action=edit Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34935&action=edit Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. Conflicts with bug 12059 fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34933|0 |1 is obsolete| | Attachment #34934|0 |1 is obsolete| | Attachment #34935|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34969&action=edit [PASSED QA] Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34969|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34970&action=edit [PASSED QA] Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34971&action=edit [PASSED QA] Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34972&action=edit [PASSED QA] Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Oh, sorry for that. I think it was a typo using git-bz. Will test right now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at some point. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org