[Bug 12970] New: Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Bug ID: 12970 Summary: Refactor VAT and price calculation - basket page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 12969 introduces a subroutine to centralize the VAT and price calculation. The basket page should use it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31747&action=edit Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12826 Depends on| |12969 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31881&action=edit Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31882&action=edit Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31747|0 |1 is obsolete| | --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31954&action=edit Bug 12970: Use the centralize VAT and prices calculation - basket.pl I've applied the 3 patches against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31881|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31955&action=edit Bug 12970: Format totals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31882|0 |1 is obsolete| | --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31956&action=edit Bug 12970: Cancelled orders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by bug 12896 currently not applying. :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12128 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33572&action=edit Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34964&action=edit [PASSED QA] Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34965&action=edit [PASSED QA] Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34966&action=edit [PASSED QA] Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34967&action=edit [PASSED QA] Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33572|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at s ome point. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org