[Bug 42925] New: Replace the 'clear' button with an icon inside the search box (global search for tables)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Bug ID: 42925 Summary: Replace the 'clear' button with an icon inside the search box (global search for tables) Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- On Chrome there is a builtin 'x' in the search box. The "Clear filter" button is then not needed. However it does not exist for Firefox. We could disable the builtin feature in Chrome add our own, so all browsers have it. Then the "Clear filter" button will no longer be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201046&action=edit Bug 42925: Replace the 'clear' button with an icon inside the search box On Chrome there is a builtin 'x' in the search box. The "Clear filter" button is then not needed. However it does not exist for Firefox. We could disable the builtin feature in Chrome add our own, so all browsers have it. Then the "Clear filter" button will no longer be needed. Test plan: 0. Rebuilt the CSS files: % yarn css:build Refresh the browser's cache, or use a private window Then, with both Firefox and Chrome (and any others web browsers you have): 1. Go to /cgi-bin/koha/admin/branches.pl => Notice that the "Clear filters" button is gone 2. Start typing in the global search => The table filters => The "x" icon is there when the input is not empty 3. Copy shareable link 4. Click the "x" icon => The table refreshes => The "x" is no longer visible 5. Use the shareable link => The global search is there => The "x" icon is visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201047&action=edit Bug 42925: (follow-up) Make clear button focusable Patch from commit 4e487a2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 [Bug 38185] DT - replace dom with layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201046|0 |1 is obsolete| | Attachment #201047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 201127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201127&action=edit Bug 42925: Replace the 'clear' button with an icon inside the search box On Chrome there is a builtin 'x' in the search box. The "Clear filter" button is then not needed. However it does not exist for Firefox. We could disable the builtin feature in Chrome add our own, so all browsers have it. Then the "Clear filter" button will no longer be needed. Test plan: 0. Rebuilt the CSS files: % yarn css:build Refresh the browser's cache, or use a private window Then, with both Firefox and Chrome (and any others web browsers you have): 1. Go to /cgi-bin/koha/admin/branches.pl => Notice that the "Clear filters" button is gone 2. Start typing in the global search => The table filters => The "x" icon is there when the input is not empty 3. Copy shareable link 4. Click the "x" icon => The table refreshes => The "x" is no longer visible 5. Use the shareable link => The global search is there => The "x" icon is visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 201128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201128&action=edit Bug 42925: (follow-up) Make clear button focusable Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the global release notes| |search for tables (where | |DataTables are used), so | |that: | |- The 'X' to clear a search | |works across Chrome and | |Firefox based browsers. | |- Removes the 'X Clear | |filter' option. | |- The 'X' to clear the | |search can be navigated to | |using the tab key (that is, | |it can be accessed when | |using keyboard navigation). | | | |Previously, the 'X' to | |clear an active table | |search only appeared in | |Chrome-based browsers, and | |wasn't visible in | |Firefox-based browsers. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201127|0 |1 is obsolete| | Attachment #201128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 204234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204234&action=edit Bug 42925: Replace the 'clear' button with an icon inside the search box On Chrome there is a builtin 'x' in the search box. The "Clear filter" button is then not needed. However it does not exist for Firefox. We could disable the builtin feature in Chrome add our own, so all browsers have it. Then the "Clear filter" button will no longer be needed. Test plan: 0. Rebuilt the CSS files: % yarn css:build Refresh the browser's cache, or use a private window Then, with both Firefox and Chrome (and any others web browsers you have): 1. Go to /cgi-bin/koha/admin/branches.pl => Notice that the "Clear filters" button is gone 2. Start typing in the global search => The table filters => The "x" icon is there when the input is not empty 3. Copy shareable link 4. Click the "x" icon => The table refreshes => The "x" is no longer visible 5. Use the shareable link => The global search is there => The "x" icon is visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 204235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204235&action=edit Bug 42925: (follow-up) Make clear button focusable Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Testing further with 38185 - at smaller widths the X button ends up far outside of the input box - not sure if you want to fix here or on the next -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Jonathan Druart from comment #8)
(In reply to Nick Clemens (kidclamp) from comment #7)
Testing further with 38185 - at smaller widths the X button ends up far outside of the input box - not sure if you want to fix here or on the next
I don't recreate this problemf without bug 38185 so I will try and fix it there.
However I do see: https://snipboard.io/ZTPorh.jpg at width=600 It's ok if I restore `top:50%`.
Owen, could you have a quick look?
The patch I've just attached on bug 38185 fixes both problems, see "Bug 38185: (follow-up) Fix search clear icon position at narrow widths"
Looked good during testing on other bug, moving back to PQA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org