[Bug 23791] New: Allow granular control of social networks enabled by SocialNetworks syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Bug ID: 23791 Summary: Allow granular control of social networks enabled by SocialNetworks syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Librarians would like to be able to turn social networks (and email) on and off individually, rather than as a group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94031&action=edit Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref This patch updates the SocialNetworks system preference so that it offers a choice of social networks (and email) which can be enabled in the OPAC. This patch also replaces the social network images with Font Awesome icons styled so that the colors match the social networks' current branding. The old social networks sprite image is removed. To test, apply the patch and run the database update. Rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... - Go to Administration -> Global system preferences -> OPAC -> Features and find the SocialNetworks preference. - If your SocialNetworks preference was enabled, all choices should be selected. Otherwise none should be selected. - If none are selected, select them all and save. - Locate a record in the OPAC and view the details page. - The social network icons should appear as expected and function as before. - Return to system preferences in the staff client and try enabling and disabling different options, verifying each time that the OPAC reflects your choices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you have another look please? Only the Twitter link works for me, the other icons/networks don't show up. yarn build --view opac was run and also multiple restart all... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94107&action=edit Bug 23791: (follow-up) Fix database update description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94375&action=edit Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Follow the previous test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94375|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 94379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94379&action=edit Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Follow the previous test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94031|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94380&action=edit Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref This patch updates the SocialNetworks system preference so that it offers a choice of social networks (and email) which can be enabled in the OPAC. This patch also replaces the social network images with Font Awesome icons styled so that the colors match the social networks' current branding. The old social networks sprite image is removed. To test, apply the patch and run the database update. Rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... - Go to Administration -> Global system preferences -> OPAC -> Features and find the SocialNetworks preference. - If your SocialNetworks preference was enabled, all choices should be selected. Otherwise none should be selected. - If none are selected, select them all and save. - Locate a record in the OPAC and view the details page. - The social network icons should appear as expected and function as before. - Return to system preferences in the staff client and try enabling and disabling different options, verifying each time that the OPAC reflects your choices. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94107|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94381&action=edit Bug 23791: (follow-up) Fix database update description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94379|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94382&action=edit Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Follow the previous test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org