[Bug 23712] New: Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Bug ID: 23712 Summary: Silence warns from Koha/Illrequest/Logger.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no If you run this: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev you get a lot of errors like this: no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. This is because C4::Templates::_get_template_file() is called with just two parameters, when it expects a CGI object as the third parameter: C4::Templates::_get_template_file('ill/log/', 'intranet'); Patch coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- There are probably many ways to solve this, but I will propose to add a new CGI object and pass it along. Alternative solutions welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 93376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93376&action=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93376|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 93441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93441&action=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Illrequests.t .. 4/11 Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 859. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93441|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94407&action=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94408&action=edit Bug 23712: (QA follow-up) Silence two other warns too Caused by undefined method: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 859. Test plan: Run test again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org