[Bug 40165] New: Incomplete logic for controlling display of OPAC language footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Bug ID: 40165 Summary: Incomplete logic for controlling display of OPAC language footer Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, nina.martinez@biblibre.com, oleonard@myacpl.org, testopia@bugs.koha-community.org Blocks: 39890 If you have opaclanguagesdisplay turned on and OpacLangSelectorMode set to "both" or "footer," BUT you only have one language enabled, an empty footer bar might be shown when these prefs are off: - OPACReportProblem - CookieConsent - OpacKohaUrl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 [Bug 39890] Accessibility: Add more Bypass blocks to the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183345&action=edit Bug 40165: Incomplete logic for controlling display of OPAC language footer This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |roman.dolny@jezuici.pl --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- It works as described for "en". Empty footer is not shown when opaclanguagesdisplay is on, OpacLangSelectorMode both/footer, CookieConsent off, OpacKohaUrl off, OPACLanguages has "en" checked ("pl-PL" not checked). Changing selection in OPACLanguages spoils performance. When in OPACLanguages "pl-PL" is checked and "en" not checked then empty footer appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Did you update the pl-PL templates after applying the patch? I should have included it in the test plan: gulp po:update --lang pl-PL perl misc/translator/translate install pl-PL Otherwise the changes in the English templates don't get copied over to your translated templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Owen Leonard from comment #3)
Did you update the pl-PL templates after applying the patch? I should have included it in the test plan: ...
No, I didn't update templates. Thank you for hint. Now it is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183345|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 183409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183409&action=edit Bug 40165: Incomplete logic for controlling display of OPAC language footer This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183409|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183900&action=edit Bug 40165: Incomplete logic for controlling display of OPAC language footer This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to add or edit in the Koha manual regarding this fix. Please reopen and provide more information is this is not the case. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org