[Bug 8347] New: Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Priority: P5 - low Change sponsored?: --- Bug ID: 8347 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Koha forces UNIMARC 100 field code language to 'fre' Severity: enhancement Classification: Unclassified OS: All Reporter: frederic@tamil.fr Hardware: All Status: NEW Version: rel_3_10 Component: Cataloging Product: Koha Reported on Koha mailing list: I can not change the UNIMARC 100 FIELD Language of cataloging. I changed the default "fre" to "chi", I saved it . But I find all 100 FIELD Language of cataloging are "fre" again. Take a look at C4/Biblio.pm module, line 3547: substr( $string, 22, 6, "frey50" ); Check also rebuild_zebra.pl fix_unimarc_100() function. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4368, 8136 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes@keep.pt --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- This should be a system preference. I've done a similar patch to authorities 100 field, where the default language was french to. I can devellop a patch for this, where "frey50" should the default value of the system preference. Cataloguing tab -> Record structure section UNIMARCField100 = "frey50" What you think about this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |vfernandes@keep.pt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 --- Comment #2 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13761&action=edit BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Added a new system preference to set the UNIMARC field 100 default language. The default value for that system preference is 'fre'. Changed Biblio.pm to use the system preference: - if the language is bad filled in the preferences it uses 'fre' as default value - only replaces the language when the field 100 is empty - if the language is filled with the plugin only replaces the positions 25-28 to 'y50' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 --- Comment #3 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13883&action=edit BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Forget to add the system preference to the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 --- Comment #4 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13897&action=edit BUG - Koha forces UNIMARC 100 field code language to 'fre' Changed Charset.pm to use defaultlanguage instead of 'fre'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Rolando Isidoro <rolando.isidoro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |rolando.isidoro@gmail.com --- Comment #5 from Rolando Isidoro <rolando.isidoro@gmail.com> --- Tested and working in version 3.8.5. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |unspecified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Rolando Isidoro <rolando.isidoro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9453 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13761|0 |1 is obsolete| | Attachment #13883|0 |1 is obsolete| | Attachment #13897|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15483&action=edit [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Added a new system preference to set the UNIMARC field 100 default language. The default value for that system preference is 'fre'. Changed Biblio.pm to use the system preference: - if the language is bad filled in the preferences it uses 'fre' as default value - only replaces the language when the field 100 is empty - if the language is filled with the plugin only replaces the positions 25-28 to 'y50' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15483|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15484&action=edit [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Forget to add the system preference to the template. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15484|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15485&action=edit [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Changed Charset.pm to use defaultlanguage instead of 'fre'. http://bugs.koha-community.org/show_bug.cgi?id=8347 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. 1) Check system preference was added correctly: UNIMARCField100Language 2) Change code in preference to be not 'fre'. 3) Catalog a bibliographic record. - check plugin shows new value - check empty field is filled with new value from the plugin - check you can still edit it to be something else -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15484|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15483|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- This does not apply on 3.10.x please rebase and submit if you wish it on that branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 --- Comment #11 from Vitor Fernandes <vfernandes@keep.pt> --- Chris, For me it's fine to only appear in 3.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org