[Bug 9662] New: z3950_search.pl ISSN search field not passed to Z3950Search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 Bug ID: 9662 Summary: z3950_search.pl ISSN search field not passed to Z3950Search Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: dpavlin@rot13.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 15549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15549&action=edit Bug 9662 - ISSN search field not passed to Z3950Search Seems like simple omission when passing $pars hash to Z3950Search function. Test scenario: 1. select any Z39.50 search form and enter valid ISSN 2. verify that you don't get any results from remote servers 3. apply this patch and re-check that results are now availble -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15565&action=edit Bug 9662 - ISSN search field not passed to Z3950Search Seems like simple omission when passing $pars hash to Z3950Search function. Test scenario: 1. select any Z39.50 search form and enter valid ISSN 2. verify that you don't get any results from remote servers 3. apply this patch and re-check that results are now availble Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15566&action=edit Bug 9662: Followup for acquisition Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial change corresponding with Dobrica's patch at cataloging side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |dpavlin@rot13.org QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Two easy one line patches making lots of people happy searching on ISSN :) Looks good to me. (Probably forgot to add this field myself..) Have been so bold to add the second patch myself instead of harassing Dobrica.. Passed QA Dobrica: If you read this before Jared does, please feel free to check.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply on 3.10.x please submit a patch for it if you wish it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9662 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
Does not apply on 3.10.x please submit a patch for it if you wish it.
The patches are only relevant for master, not for 3.10.x or lower.. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org