[Bug 33312] New: Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Bug ID: 33312 Summary: Add circulation and fines rules table from smart-rules.pl to column settings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be very helpful to be able to configure hiding columns as libraries rarely (if ever) use all the columns (suspensions vs fines, etc.) Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Thanks for filing this! I've voiced my intent to do so too many times :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com, | |lisette.scheer@bywatersolut | |ions.com, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanel.wheeler@yavapaiaz.go | |v --- Comment #2 from Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> --- I would find this useful as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #3 from Laura O'Neil <laura@bywatersolutions.com> --- Yes please! Being able to configure the circ/fine rules table would be so nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41439 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 tech.aimee@salinapublic.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tech.aimee@salinapublic.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #4 from Laurence Rault <laurence.rault@biblibre.com> --- +1 from Hackfest 2026 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I can have a look but it may be tricky to implement if we have bug 41604. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203857&action=edit Bug 33312: Add table settings to default-circulation-rules table To test: 1. APPLY PATCH and restart_all 2. Go to Admin -> Circulation rules 3. Notice the Columns button ( gear icon ) 4. Attempt to hide columns using the Columns button, make sure the correct columns are being hidden 5. Turn on 'UseRecalls' , 'UnseenRenewals', and 'ArticleRequests', that will make some additional columns appear. 6. Make sure you can hide everything correctly. 7. Go to Admin -> Table settings and find the new 'smart-rules' entry under admin. 8. Hide all the columns and make sure they are correctly hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
I can have a look but it may be tricky to implement if we have bug 41604.
I attached something that seems pretty straightforward. Not sure what I might be missing here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #7)
(In reply to Jonathan Druart from comment #5)
I can have a look but it may be tricky to implement if we have bug 41604.
I attached something that seems pretty straightforward. Not sure what I might be missing here?
I guess I meant bug 41439, not bug 41604. But we should also remove the conditionals around the th, and this is related to bug 41604. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I think this would still be useful on top of 41439, though it certainly adds complexity. 41439's subsets of rules are easier to look at than the whole table, but are still pretty wide and likely to contain columns many libraries would be happy to never think about. I suppose that if a library has hidden all the columns within any given tab then the tab should be hidden as well -- this seems most likely to happen with the Fines tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #10 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- Created attachment 205392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205392&action=edit Bug 33312: Add table settings to default-circulation-rules table To test: 1. APPLY PATCH and restart_all 2. Go to Admin -> Circulation rules 3. Notice the Columns button ( gear icon ) 4. Attempt to hide columns using the Columns button, make sure the correct columns are being hidden 5. Turn on 'UseRecalls' , 'UnseenRenewals', and 'ArticleRequests', that will make some additional columns appear. 6. Make sure you can hide everything correctly. 7. Go to Admin -> Table settings and find the new 'smart-rules' entry under admin. 8. Hide all the columns and make sure they are correctly hidden Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Lucas Gass (lukeg) from comment #7)
(In reply to Jonathan Druart from comment #5)
I can have a look but it may be tricky to implement if we have bug 41604.
I attached something that seems pretty straightforward. Not sure what I might be missing here?
I guess I meant bug 41439, not bug 41604.
But we should also remove the conditionals around the th, and this is related to bug 41604.
Again a typo in the bug number! Read: "But we should also remove the conditionals around the th, and this is related to bug 42332" And this is still valid. Please rebase on top of 42332. bKohaColumnsUseNames does not work correctly without it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Also please clarify, would this be only for stable releases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #12)
Also please clarify, would this be only for stable releases?
Why would this only be for stable releases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #13)
(In reply to Jonathan Druart from comment #12)
Also please clarify, would this be only for stable releases?
Why would this only be for stable releases?
Because bug 41439 is, I think, targeting 26.11. Won't they conflict? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Lucas Gass (lukeg) from comment #13)
(In reply to Jonathan Druart from comment #12)
Also please clarify, would this be only for stable releases?
Why would this only be for stable releases?
Because bug 41439 is, I think, targeting 26.11. Won't they conflict?
Yes, I just reviewed Bug 41439 and thought maybe they could co-exist but I don't think they can. Closing this one. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org