https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189714&action=edit Bug 41273: Parallelize test execution for improved performance This patch adds parallel processing to xt/perltidy.t using Parallel::ForkManager, following the same pattern as xt/pl_valid.t and xt/tt_tidy.t. Changes: - Uses Parallel::ForkManager to process files concurrently - Auto-detects CPU count via Sys::CPU (respects KOHA_PROVE_CPUS env var) - Preserves working directory context in forked child processes - Maintains correct failure tracking in %results hash Performance improvement: ~N× speedup on N-core systems (e.g., 8× faster on 8-core, 16× faster on 16-core machines) Test plan: 1. Clear incremental test cache (if needed): docker exec kohadev-koha bash -c 'rm -rf /tmp/koha-ci-results/perltidy*' 2. Run test: docker exec kohadev-koha bash -c 'KOHA_PROVE_CPUS=8 prove xt/perltidy.t' 3. Verify all 3138 tests pass 4. Verify test completes significantly faster than before -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- +# Capture the current working directory before forking +my $cwd = getcwd(); + # Ensure we're in the correct directory in the forked process + chdir($cwd); Do we really need that? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189714|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks Katrin, and Joubu for the review. You are right, we don't need it: a forked child inherits the working directory of its parent, so there is nothing to restore, and the other parallel tests (xt/tt_tidy.t, xt/pl_valid.t, t/db_dependent/00-strict.t) don't do it either. I have removed the getcwd/chdir lines and the Cwd import (attachment replaced). To check, I ran the whole of xt/perltidy.t in KTD with KOHA_PROVE_CPUS=6 without them: all 3373 files resolve their relative paths correctly in the workers. The one failure is t/db_dependent/api/v1/messages.t, which is not tidy on main (the file is not touched by this patch, it comes from bug 23998), so the full run currently fails regardless of this patch until that file is tidied. Setting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Please don't forget we have bug 43505 in the queue... Also if you really want to speed it up you should simply use KOHA_CI_INCREMENTAL_RUNS=1 -- You are receiving this mail because: You are watching all bug changes.