[Bug 29242] New: Flatpickr - Should autocomplete be turned off?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Bug ID: 29242 Summary: Flatpickr - Should autocomplete be turned off? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Without autocomplete turned off: https://usercontent.irccloud-cdn.com/file/9NZax9ln/image.png Should we turn it off? On Chrome it appears right after the input has the focus, on Firefox you have to double click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I like having the browser's autocomplete, but that may just be because I'm almost always in testing mode rather that using it live. We could set the autocomplete attribute upon initialization of the Flatpickr instance and avoid making any changes to the templates. Another idea is to tie into the "keydown" function we already have and set autocomplete to "on" if the user types a key other than an arrow key. Probably overkill. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126302&action=edit Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126302|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 126408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126408&action=edit Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126408|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127140&action=edit Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flatpickr - Should |Flatpickr - Turn |autocomplete be turned off? |autocomplete off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org