[Bug 29351] New: Add missing cn_source parameter to reports parameter menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Bug ID: 29351 Summary: Add missing cn_source parameter to reports parameter menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, jrobb@sekls.org, koha-bugs@lists.koha-community.org, testopia@bugs.koha-community.org Depends on: 27644 There has always been a cn_source ("Source of classification or shelving scheme") runtime parameter available to SQL reports, although it isn't mentioned in the wiki. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 [Bug 27644] Add button to SQL report editor for inserting runtime parameters -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 [Bug 29352] Runtime parameter labels should not be said to be optional -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I didn't know this was an option! Good catch! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127063&action=edit Bug 29351: Add missing cn_source parameter to reports parameter menu This patch adds an option to insert "Source of classification or shelving scheme" as a runtime parameter in SQL reports. The ability to use cn_source as a parameter seems to have always been part of this feature but wasn't documented. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Classification source." - Customize the parameter label if you wish and click "Insert parameter." - The parameter should be inserted like this: <<Source of classification or shelving scheme|cn_source>> - Use it to create a valid SQL report, for example: SELECT * FROM items WHERE cn_source = <<Source of classification or shelving scheme|cn_source>> LIMIT 10 - Confirm that upon running the report you are prompted to select a classification source. - Confirm that the report runs correctly. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting this error when trying to run my report: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_reports_guided_reports_2epl::GetClassSources called at /kohadevbox/koha/reports/guided_reports.pl line 761 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Sorry, I should have put this in the test plan: There is a followup on Bug 17600 which is required for GetClassSources to work: See comment 148 on that bug. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127063|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127069&action=edit Bug 29351: Add missing cn_source parameter to reports parameter menu Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks! I Was able to test successfully after I applied your patch from 17600. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Bug 29351 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127069|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127116&action=edit Bug 29351: Add missing cn_source parameter to reports parameter menu This patch adds an option to insert "Source of classification or shelving scheme" as a runtime parameter in SQL reports. The ability to use cn_source as a parameter seems to have always been part of this feature but wasn't documented. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Classification source." - Customize the parameter label if you wish and click "Insert parameter." - The parameter should be inserted like this: <<Source of classification or shelving scheme|cn_source>> - Use it to create a valid SQL report, for example: SELECT * FROM items WHERE cn_source = <<Source of classification or shelving scheme|cn_source>> LIMIT 10 - Confirm that upon running the report you are prompted to select a classification source. - Confirm that the report runs correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch adds a link for release notes| |the previously-hidden | |option of using a runtime | |parameter for selecting | |"Source of classification | |or shelving scheme." Now | |when composing an SQL | |report you can click the | |"Insert runtime parameter" | |button to see a menu that | |includes this option. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Bug 29351 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org