[Bug 5687] New: Add preference for display of AuthorisedValueImages at staff search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Summary: Add preference for display of AuthorisedValueImages at staff search results Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: PATCH-Sent Component: Staff Client AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 At OPAC side the preference AuthorisedValueImages already exists. In staff client, the search results always include these images. If they are not found, they are replaced by itemtype desc. This results in results like: 4. Iznik pottery and tiles in the Calouste Gulbenkian collection / Queiroz Ribeiro, Maria Description: [London] : Scala, 2009 : 136 p. : ; 31 cm. ISBN: 9728848587 Collection catalogs Collection catalogs Collection catalogs NOTE: The three Collection catalogs (itemtype desc) refer to three authorised values: a relator code, a relator term and a itemtype. This make no sense. (We made an authorised list for relator codes and terms.) The new preference AuthorisedValueImages adds the option to hide display of the images or the duplicate alternative descriptions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-03 12:11:02 UTC --- Created attachment 3056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3056 Patch (for functionality) This patch contains the relevant code. The followup patch only adds installation: adding the pref at upgrade or install time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-03 12:12:51 UTC --- Created attachment 3057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3057 Patch (for install) This followup patch only contains installation: adding the pref at upgrade or install time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3057|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-03 12:15:01 UTC --- Created attachment 3058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3058 Patch (for install) This followup patch only contains installation: adding the pref at upgrade or install time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-02-04 00:29:05 UTC --- I'm not sure what effect this code has. The TMPL_VAR authorised_value_images is never set by catalogue/search.pl and so should never show up in results.tmpl in spite of being checked for there. If the result display is malformed, perhaps there is another syntax problem within the results.tmpl template. Or have I missed something in my testing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-04 07:46:02 UTC --- Thank you for testing. Like to respond to your comments however: The TMPL_VAR is set in a module: C4/Search.pm, searchResults (called by catalogue/search.pl) $oldbiblio->{'authorised_value_images'} = C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) ); It certainly shows up. See the example below. I eliminated it by first testing with the template. I do not suspect any syntax problem here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-02-04 13:42:01 UTC --- (In reply to comment #5)
Thank you for testing. Like to respond to your comments however:
The TMPL_VAR is set in a module:
C4/Search.pm, searchResults (called by catalogue/search.pl)
$oldbiblio->{'authorised_value_images'} = C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) );
It certainly shows up. See the example below. I eliminated it by first testing with the template. I do not suspect any syntax problem here.
I see it now. It is part of the newresults array in search.pl. So a couple of questions: 1. How do I get authorised_value_images to populate? 2. Can you attach screen shots showing what the problem is and what the fix looks like? Thanks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-07 08:55:58 UTC --- Created attachment 3067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3067 Screen shot 1 Shows duplicate item type descriptions (alternative text for authorised value images) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-07 08:57:03 UTC --- Created attachment 3068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3068 Screen shot 2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-07 09:01:29 UTC ---
How do I get authorised_value_images to populate?
Please see Comment1 also. Attach an authorised value list to a field in your framework, and use that in a record. We did so for item type, relator code and relator term. This generates either images or alternative text (if no image was found) for each one. See e.g. the second or fourth record in the screenshot. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3056|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-07 13:51:58 UTC --- Created attachment 3073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3073 Revised patch (functionality) Commit 0088c5da53a56f44ec435f88a56b67ae99616a4d renamed staff_client.pref file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #11 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-04 10:26:59 UTC --- This bug is mentioned in: Bug 5687: Add pref StaffAuthorisedValueImages for staff search results http://lists.koha-community.org/pipermail/koha-patches/2011-February/013752.... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results http://lists.koha-community.org/pipermail/koha-patches/2011-February/013753.... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results http://lists.koha-community.org/pipermail/koha-patches/2011-February/013771.... --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-03-09 19:35:54 UTC --- I'd recommend that a conditional be added to C4::Search::searchResults to only populate $oldbiblio->{'authorised_value_images'} if they're going to be used by the requesting search results page. That is: IF (($search_context == 'opac' and AuthorisedValueImages) OR ($search_context == 'intranet' and StaffAuthorisedValueImages)) The call to get authorised values can be very expensive, and if it's not going to be used in the output, we could save ourselves some processing time (possibly over 1 second's worth) when performing a search by never invoking the subroutine. This would also simplify the template: we wouldn't need a nested conditional for both the system preference AuthorisedValueImages and the existence of the images themselves; they would only exist if they were supposed to. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #13 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-03-09 20:22:56 UTC --- +1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3073|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-10 08:38:11 UTC --- Created attachment 3278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3278 Revised patch (functionality) Revised patch populates authvalimages only if needed. No changes to template or search.pl needed anymore. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3058|0 |1 is obsolete| | --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-10 08:59:50 UTC --- Created attachment 3279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3279 Revised patch (install) Revised patch for installation of new syspref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3279|0 |1 is obsolete| | --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-17 14:22:46 UTC --- Created attachment 3341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3341 Patch for install (updated) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #17 from Ian Walls <ian.walls@bywatersolutions.com> 2011-03-26 00:02:08 UTC --- The revised patch for functionality works! Running a search through NYTProf before, I was getting over 1.29 s inclusive time spent on 20 instances of get_biblios_authorised_values. That has now disappeared, and has not recurred in other places. Also tested manually, by counting seconds for searches to return. Dropped from 4 seconds to 3 seconds, which I would call quite significant. If you pass along the full install patch, I'll happily sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3341|0 |1 is obsolete| | --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-28 07:48:42 UTC --- Created attachment 3459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3459 Patch for install (updated) Rebased on March 28 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-28 07:50:27 UTC --- (In reply to comment #17)
The revised patch for functionality works! Running a search through NYTProf before, I was getting over 1.29 s inclusive time spent on 20 instances of get_biblios_authorised_values. That has now disappeared, and has not recurred in other places. Also tested manually, by counting seconds for searches to return. Dropped from 4 seconds to 3 seconds, which I would call quite significant. If you pass along the full install patch, I'll happily sign off
Thanks for testing, Ian. I rebased the install patch. So if you could sign both patches, please go ahead. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #20 from Ian Walls <ian.walls@bywatersolutions.com> 2011-03-30 00:51:48 UTC --- Signed off patches sent to list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed Severity|normal |enhancement --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-30 06:53:40 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-30 11:38:35 UTC --- Works for me. Thanks for signoff and push. Anyone else to close it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-05 14:48:43 UTC --- Can someone give me the steps to follow in order to view these images? I don't manage to get them... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #24 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-04-05 14:51:40 UTC --- (In reply to comment #23)
Can someone give me the steps to follow in order to view these images? I don't manage to get them...
Just clicking on the links causes them to display in my browser (FF). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-05 15:22:17 UTC --- (In reply to comment #24)
Just clicking on the links causes them to display in my browser (FF).
Maybe I wasn't clear, setting StaffAuthorisedValueImages to "Show" or "Don't Show" doesn't make any changes. The only images I see in search results are the itemtype images. The description of this system preference is talking about lost statuses and locations, so I try to "attach" an image to theses authorised values, and change the status of some items to "Lost", for example. I don't see any changes. Can you be more precise please? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-04-06 12:07:26 UTC --- (In reply to comment #25)
(In reply to comment #24)
Just clicking on the links causes them to display in my browser (FF). Maybe I wasn't clear, setting StaffAuthorisedValueImages to "Show" or "Don't Show" doesn't make any changes. The only images I see in search results are the itemtype images. The description of this system preference is talking about lost statuses and locations, so I try to "attach" an image to theses authorised values, and change the status of some items to "Lost", for example. I don't see any changes. Can you be more precise please?
Please see problem description. In screen shots you see repeated item type descriptions like "Collection catalogs Collection catalogs Collection catalogs". (The text is already an alternative for an image.) This comes from authorized values used on relator codes and relator terms. If you would not use authorized values on such fields, you will not see it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 --- Comment #27 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-11 08:32:00 UTC --- This bug is mentioned in: Bug 5687: Add pref StaffAuthorisedValueImages for staff search results http://lists.koha-community.org/pipermail/koha-patches/2011-March/014018.htm... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014019.htm... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014113.htm... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014255.htm... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results http://lists.koha-community.org/pipermail/koha-patches/2011-March/014332.htm... Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014333.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #28 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-05-12 07:29:50 UTC --- Closing this bug myself. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org