http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35673&action=edit Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35673|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35675&action=edit Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35675|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35729&action=edit [PASSED QA] Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> could not confirm the problem, but small change and highlighting terms on result list and couldn't find any regressions in highlighting. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tomas, Kyle, Do you confirm the problem existed before this patch (I didn't test)? Because this case should be take into account with another line: if ( q_array[x].length > 0 ) { There have been a lot of other reports for this issue (at least bug 10956, bug 9419 and bug 8646), and this line does not exist at the other places. That makes me think that this patch was unnecessary. -- You are receiving this mail because: You are watching all bug changes.