[Bug 13728] New: koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Bug ID: 13728 Summary: koha-translate -l -a shows po files instead of language codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org When 'prog' got removed the koha-translate was fixed so it uses the bootstrap .po files to check language availability, but a leftover (-i-) makes $ koha-translate --list --available incorrectly show the .po file names instead of the language codes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35993&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35993|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36013&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36013|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36036&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org