http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13614|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13615&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13615|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch complexity|--- |Medium patch Severity|enhancement |new feature --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- I wanted to be a on the CC list for this bug, but had to set a patch complexity to do so - update if I was wrong in my assumptions. Nicole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13616|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14553&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Original test plan Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Added: Max sure you have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14553|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16197&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The logic on this syspref is backwards. When set to "Don't allow," the fine assessed will be equal to the maximum fine allowed by the circ rules, and when set to "Allow" the fine assessed will be equal to the replacement price of the item. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17990|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17991&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #15 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #10)

The logic on this syspref is backwards. When set to "Don't allow," the fine assessed will be equal to the maximum fine allowed by the circ rules, and when set to "Allow" the fine assessed will be equal to the replacement price of the item.

I've attached a trivial followup to fix this issue. I've set "Passed QA" under the assumption that this is the only issue you found. If I am mistaken, please reset the status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #9)

One remark. IMO this pref and MaxFine should really be at the Circulation tab under Fines policy. All other Patron prefs have no direct connection to Circulation as well as Fines.

To agree with and intensify what Marcel said ... IMO this *really* needs to be an attribute of issuingrules, not a system preference. Different libraries sharing a Koha database might have different preferences on setting the max fine, and I can imagine cases where a library might want this to vary by item type. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #17)

Hm, I think Marcel meant the the Patrons tab in the system preference editor is not the right place, but that it should be in Circulation.

That is actually what I meant to write, taking one step at a time. But Galen is two steps further and I agree with him too :) It is confusing to configure circulation on two platforms: prefs and rules, not even talking about making it itemtype dependent. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #20 from Kyle M Hall <kyle.m.hall@gmail.com> --- One nice feature of this patch as it stands is that you can specify both MaxFine and MaxFineIsReplacementPrice at once. If the replacement price is over the MaxFine, it will be reduced. To move it to the circulation matrix would require a full re-write. The overduefinescap functions within CalcFine, rather than UpdateFine. Perhaps we have fines logic in too many places. Maybe MaxFines logic needs to be moved to CalcFine as well. (In reply to comment #19)

(In reply to comment #17)

...

Hm, I think Marcel meant the the Patrons tab in the system preference editor is not the right place, but that it should be in Circulation.

Indeed, I had in fact misread what Marcel meant, although I see that he also agrees with where I ended up after my misreading. :)

...

With 3.12 we have MaxFine in the circulation matrix - not sure how the best way would be to indicate that it should be using the replacement price there. It's an input field, so maybe a checkbox that implies 'replacement price' and deactivates the maxfine input field?

That makes sense to me -- a checkbox for "cap overdue fine at replacement price" that then disables the maxfine input field.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18366|0 |1 is obsolete| | --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18367&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Resolved small merge conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18371&action=edit Bug 9129: Followup for moving two maxfine prefs to Circulation Moving two fines prefs from Patrons to Circulation/Fines Policy. Rewording no=Allow to exceed to no=Do not use for more clarity :) Test plan: Check if you can still find them.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #28 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #20)

One nice feature of this patch as it stands is that you can specify both MaxFine and MaxFineIsReplacementPrice at once. If the replacement price is over the MaxFine, it will be reduced.

To move it to the circulation matrix would require a full re-write. The overduefinescap functions within CalcFine, rather than UpdateFine.

Perhaps we have fines logic in too many places. Maybe MaxFines logic needs to be moved to CalcFine as well.

I agree with Galen that moving them both out of the prefs would be great. But adjusting a lot of troublesome circulation code would be great too. All together, I do no think that we should block this patch for that reason. BTW Kyle should be the ideal candidate to get the code in CalcFine and UpdateFine on a higher level as followup :) Moving the status back to Passed QA for final RM comment. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #30 from Kyle M Hall <kyle.m.hall@gmail.com> --- Galen, if you feel strongly this is the way to go, I will do it that way. I'm fully invested in making Koha the best ILS it can be! Also, as far as the fines logic goes, for this I will do whatever is necessary to make it function, but I'm still preparing a full-rewrite of the accounts system, so I'll probably just shore this up with the minimum amount of code, as the rewrite will replace it eventually. It really does seem more logical to have CalcFine deal with all fine limiting activities, rather than UpdateFine. However, there may be consequences I'm not seeing. Kyle (In reply to comment #29)

(In reply to comment #28)

...

...

Perhaps we have fines logic in too many places. Maybe MaxFines logic needs to be moved to CalcFine as well.

I agree with Galen that moving them both out of the prefs would be great. But adjusting a lot of troublesome circulation code would be great too.

The thing is, not taking the time to set a new circ policy switch at the right level of specificity just adds to the refactoring work that has to be done later.

Setting back to in discussion to ask the question of Kyle directly: are you willing to prepare a version of this patch that adds this limit as a issuingrules policy, not a system preference?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I wasn't aware of your RFC until reading about it here on the bug - maybe you could update the wiki page and send a mail to the mailing list about it? People might have good suggestions/comments. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18367|0 |1 is obsolete| | Attachment #18370|0 |1 is obsolete| | Attachment #18371|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18642&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #36 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Using index info to reconstruct a base tree... M C4/Overdues.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Overdues.pm Patch failed at 0001 Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18643|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23305&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Holger, thx for testing! Reading your comment I think this is a failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23305|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43252&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43253|0 |1 is obsolete| | --- Comment #42 from Cindy Murdock Ames <cmurdock@ccfls.org> --- Created attachment 43298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43298&action=edit [SIGNED OFF] [patch] Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Patch applied without error and test plan produced expected result of a fine equalling the replacement cost price. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some conflicts, due to recent changes in master (I suspect for the on-site quotas), please fix: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Using index info to reconstruct a base tree... M Koha/Schema/Result/Issuingrule.pm M admin/smart-rules.pl M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm Failed to merge in the changes. Patch failed at 0001 Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-patch-Bug-9129---Add-the-ability-to-set-G3gYvN.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43298|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43592&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43686&action=edit Bug 9129 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43685|0 |1 is obsolete| | Attachment #43686|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43688&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this something to worry about? $ perl t/db_dependent/Circulation/CalcFine.t 1..2 DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. # Subtest: Test basic functionality 1..1 ok 1 - Amount is calculated correctly ok 1 - Test basic functionality # Subtest: Test cap_fine_to_replacement_price 1..1 ok 1 - Amount is calculated correctly ok 2 - Test cap_fine_to_replacement_price DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0x432c8c0), attempting ROLLBACK anyway at /home/katrin/kohaclone/t/lib/TestBuilder.pm line 363 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43746&action=edit Bug 9129 - Update schema Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43781&action=edit [PASSED QA] Bug 9129 - Update database Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43783&action=edit [PASSED QA] Bug 9129 - Update schema Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46157&action=edit Bug 9129 [QA Followup] - Make unit test file conform to PBP Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.