http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add delete report option to |Add delete report option to |a saved report output |Show, Edit and Run screens |screen | CC| |magnus@libriotech.no Assignee|gmcharlt@gmail.com |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Because of the way the relevant templates are structured, it is easy to add the Delete link to the Show, Edit and Run screens in one go, so I have marked bug 15322 as a duplicate of this one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45509&action=edit Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Ah, when you click Delete from the list of saved reports there is a JavaScript confirmation that I missed. I'll see if I can get that to work with the new links. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Heather Braum <hbraum@nekls.org> --- I've followed the testing plan below, including the patch update in version 2, and this works as described. Thanks Magnus! Test plan: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45513|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45518&action=edit Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.