[Bug 31470] New: Incorrect selector for relationship dropdown used in members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Bug ID: 31470 Summary: Incorrect selector for relationship dropdown used in members.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |emmi.takkinen@koha-suomi.fi --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139826&action=edit Use class "relationship" instead of id "relationship" in members.js In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, could you please add a test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139826|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139939&action=edit Bug 31470: Use class "relationship" instead of id "relationship" in members.js In members.js line 112 variable guarantor_relationship is selected with id "relationship". Correct selector should however be class "relationship" since id "relationship" is used in auth-finder-search.inc, not in memberentry.pl. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. We use script to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. To test: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". Sponsored-by: Koha-Suomi O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- This highlights another problem. If relationship is going to a class in memberentry.pl then something must be done about its label: <label for="relationship">Relationship: </label> The value of the for attribute of the label element must be the ID, not a class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Lucas Gass from comment #4)
This highlights another problem. If relationship is going to a class in memberentry.pl then something must be done about its label:
<label for="relationship">Relationship: </label>
The value of the for attribute of the label element must be the ID, not a class.
Hmm, you're right. So either we change ID from auth-finder-search.inc as something like "special_relationship" to avoid conflicts and change relationship in memberentry from class to ID. Or we add new ID to memberentry (e.g. non_patron_relationship). Latter is probably preferable solution. And we could use that ID in members.js instead of class relationship (which at hindsight could cause problems in future). And looking at this more closely, we have this same problem with other label as well: <label for="guarantor_relationship">Relationship: </label> <select class="new_guarantor_relationship" name="new_guarantor_relationship"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Emmi, In this bug should we change the ID in auth-finder-search.inc. Then we can file a new bug to deal with the label problems in memberentry.pl? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139939|0 |1 is obsolete| | --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 144570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144570&action=edit Bug 31470: Add id "relationship" to memberentrygen.tt, change id "relationship" in auth-finder-search.inc In members.js line 112 variable guarantor_relationship is selected with id "relationship". However id "relationship" is used in auth-finder-search.inc, not in memberentrygen.tt. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. Script has to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. This patch changes two things. Firstly it adds id "relationship" to memberentrygen.tt so that member.js can fetch correct value to variable guarantor_relatioship. Secondly it changes id "relationship" in auth-finder-search.tt as "special_relationship" to avoid confusion. To test memberentrygen.tt: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". To test auth-finder-search.inc: 1. Add authority e.g. Chronological Term 2. Modify field 551$a, click "Tag editor" icon from right 3. Searc pop-up is opened. => Make sure that field "Special relationship" is highlighted when you hover mouse over label. => Make sure that after performing a search, search value in "Special relationship" field persists. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Made changes based on Lucas's comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Laura <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #9 from Laura <Laura.escamilla@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #7)
Created attachment 144570 [details] [review] Bug 31470: Add id "relationship" to memberentrygen.tt, change id "relationship" in auth-finder-search.inc
In members.js line 112 variable guarantor_relationship is selected with id "relationship". However id "relationship" is used in auth-finder-search.inc, not in memberentrygen.tt.
One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. Script has to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship.
This patch changes two things. Firstly it adds id "relationship" to memberentrygen.tt so that member.js can fetch correct value to variable guarantor_relatioship. Secondly it changes id "relationship" in auth-finder-search.tt as "special_relationship" to avoid confusion.
To test memberentrygen.tt: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor".
To test auth-finder-search.inc: 1. Add authority e.g. Chronological Term 2. Modify field 551$a, click "Tag editor" icon from right 3. Searc pop-up is opened. => Make sure that field "Special relationship" is highlighted when you hover mouse over label. => Make sure that after performing a search, search value in "Special relationship" field persists.
Sponsored-by: Koha-Suomi Oy
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 102 var guarantor_surname = $('#guarantor_surname').val(); 103 fieldset.find('.new_guarantor_surname').first().val( guarantor_surname ); 104 fieldset.find('.new_guarantor_surname_text').first().text( guarantor_surname ); 105 $('#guarantor_surname').val(""); 106 107 var guarantor_firstname = $('#guarantor_firstname').val(); 108 fieldset.find('.new_guarantor_firstname').first().val( guarantor_firstname ); 109 fieldset.find('.new_guarantor_firstname_text').first().text( guarantor_firstname ); 110 $('#guarantor_firstname').val(""); 111 112 var guarantor_relationship = $('#relationship').val(); 113 fieldset.find('.new_guarantor_relationship').first().val( guarantor_relationship ); 114 $('#relationship').find('option:eq(0)').prop('selected', true); This code is not clear to me, what are we trying to do? Is it really want we want? In my test I see an inconsistency: Edit a patron, fill "Non-patron guarantor" input and select Add guarantor, select an user => surname and firstname inputs are kept, but select is emptied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #11 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Jonathan Druart from comment #10)
102 var guarantor_surname = $('#guarantor_surname').val(); 103 fieldset.find('.new_guarantor_surname').first().val( guarantor_surname ); 104 fieldset.find('.new_guarantor_surname_text').first().text( guarantor_surname ); 105 $('#guarantor_surname').val(""); 106 107 var guarantor_firstname = $('#guarantor_firstname').val(); 108 fieldset.find('.new_guarantor_firstname').first().val( guarantor_firstname ); 109 fieldset.find('.new_guarantor_firstname_text').first().text( guarantor_firstname ); 110 $('#guarantor_firstname').val(""); 111 112 var guarantor_relationship = $('#relationship').val(); 113 fieldset.find('.new_guarantor_relationship').first().val( guarantor_relationship ); 114 $('#relationship').find('option:eq(0)').prop('selected', true);
This code is not clear to me, what are we trying to do? Is it really want we want?
Those guarantor_surname and guarantor_firstname blocks set guarantors name to the form. Not sure what that guarantor_relationship is supposed to do, probably same thing if guarantor already exists (tested this it doesn't, no idea what it does).
In my test I see an inconsistency: Edit a patron, fill "Non-patron guarantor" input and select Add guarantor, select an user => surname and firstname inputs are kept, but select is emptied Weird. And to add more weirdness to this, if I comment out that guarantor_relationship mentioned above, relationship remains in non-patron guarantor field set but disappears from patron guarantor :D
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #12 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It's line 114 in members.js that sets non-patron relationship empty when patron guarantor is added. $('#relationship').find('option:eq(0)').prop('selected', true); It was added in bug 14570, maybe it is a fix for "There's no way to set the relationship". But since there hasn't actually been id "relationship" it hasn't done anything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144570|0 |1 is obsolete| | --- Comment #13 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 167432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167432&action=edit Bug 31470: Add id "relationship" to memberentrygen.tt, change id "relationship" in auth-finder-search.inc In members.js line 112 variable guarantor_relationship is selected with id "relationship". However id "relationship" is used in auth-finder-search.inc, not in memberentrygen.tt. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. Script has to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. This patch changes two things. Firstly it adds id "relationship" to memberentrygen.tt so that member.js can fetch correct value to variable guarantor_relatioship. Secondly it changes id "relationship" in auth-finder-search.tt as "special_relationship" to avoid confusion. To test memberentrygen.tt: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". To test auth-finder-search.inc: 1. Add authority e.g. Chronological Term 2. Modify field 551$a, click "Tag editor" icon from right 3. Searc pop-up is opened. => Make sure that field "Special relationship" is highlighted when you hover mouse over label. => Make sure that after performing a search, search value in "Special relationship" field persists. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 167433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167433&action=edit Bug 31470: Do not change relationship value when adding a patron guarantor Adding new id "relationship" led to unexpected behaviour in relationship handling. If one edits patron with non-patron guarantor and added patron guarantor, non-patron guarantors relatioship field was set as empty value which is first option on select field. This patch removes code which sets relationship select field to use first value of option automatically when patron guarantor is added. Also thi patch add missing id to mandatory relatioship field. To test: 1. Add or edit patron. 2. Add non-patron guarantor for patron and select some value as their relationship. 3. Then add a patron guarantor. => Note that non-patron guarantors relationship is empty. 4. Apply this patch. 5. Repeat steps 1 to 3. => Relationship shouldn't change. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167432|0 |1 is obsolete| | Attachment #167433|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167842&action=edit Bug 31470: Add id "relationship" to memberentrygen.tt, change id "relationship" in auth-finder-search.inc In members.js line 112 variable guarantor_relationship is selected with id "relationship". However id "relationship" is used in auth-finder-search.inc, not in memberentrygen.tt. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. Script has to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. This patch changes two things. Firstly it adds id "relationship" to memberentrygen.tt so that member.js can fetch correct value to variable guarantor_relatioship. Secondly it changes id "relationship" in auth-finder-search.tt as "special_relationship" to avoid confusion. To test memberentrygen.tt: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". To test auth-finder-search.inc: 1. Add authority e.g. Chronological Term 2. Modify field 551$a, click "Tag editor" icon from right 3. Searc pop-up is opened. => Make sure that field "Special relationship" is highlighted when you hover mouse over label. => Make sure that after performing a search, search value in "Special relationship" field persists. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167843&action=edit Bug 31470: Do not change relationship value when adding a patron guarantor Adding new id "relationship" led to unexpected behaviour in relationship handling. If one edits patron with non-patron guarantor and added patron guarantor, non-patron guarantors relatioship field was set as empty value which is first option on select field. This patch removes code which sets relationship select field to use first value of option automatically when patron guarantor is added. Also thi patch add missing id to mandatory relatioship field. To test: 1. Add or edit patron. 2. Add non-patron guarantor for patron and select some value as their relationship. 3. Then add a patron guarantor. => Note that non-patron guarantors relationship is empty. 4. Apply this patch. 5. Repeat steps 1 to 3. => Relationship shouldn't change. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167842|0 |1 is obsolete| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171946&action=edit Bug 31470: Add id "relationship" to memberentrygen.tt, change id "relationship" in auth-finder-search.inc In members.js line 112 variable guarantor_relationship is selected with id "relationship". However id "relationship" is used in auth-finder-search.inc, not in memberentrygen.tt. One way to see what kind of effect incorrect selector has (and how I originally stumbled into this), is to add into "IntranetUserJS" a line which changes non-patron guarantors relationship default selected value as other than empty. Script has to change "relationship" instead of "new_guarantor_relationship" because selector input for patron guarantors relationship actually uses default selected value from non-patron guarantors relationship. This patch changes two things. Firstly it adds id "relationship" to memberentrygen.tt so that member.js can fetch correct value to variable guarantor_relatioship. Secondly it changes id "relationship" in auth-finder-search.tt as "special_relationship" to avoid confusion. To test memberentrygen.tt: 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. "guarantor". 2. Add following line to "IntranetUseJS": $('.relationship option:eq(1)').attr('selected', 'selected'); 3. Add guarantee patron and note that non-patron guarantors relationship is now "guarantor". 4. Add patron guarantor and note that relationship value is empty. 5. Apply this patch and refresh page. 6. Repeat step 4. => Note that now relationship value is "guarantor". To test auth-finder-search.inc: 1. Add authority e.g. Chronological Term 2. Modify field 551$a, click "Tag editor" icon from right 3. Searc pop-up is opened. => Make sure that field "Special relationship" is highlighted when you hover mouse over label. => Make sure that after performing a search, search value in "Special relationship" field persists. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167843|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171947&action=edit Bug 31470: Do not change relationship value when adding a patron guarantor Adding new id "relationship" led to unexpected behaviour in relationship handling. If one edits patron with non-patron guarantor and added patron guarantor, non-patron guarantors relatioship field was set as empty value which is first option on select field. This patch removes code which sets relationship select field to use first value of option automatically when patron guarantor is added. Also thi patch add missing id to mandatory relatioship field. To test: 1. Add or edit patron. 2. Add non-patron guarantor for patron and select some value as their relationship. 3. Then add a patron guarantor. => Note that non-patron guarantors relationship is empty. 4. Apply this patch. 5. Repeat steps 1 to 3. => Relationship shouldn't change. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I pushed some other relationship related patches today, so I tried to double check especially carefully here. I notice that we still have this line: koha-tmpl/intranet-tmpl/prog/js/members.js: var guarantor_relationship = $('#relationship').val(); But you rename the id to special_relationship and I couldn't spot an id with relationship any more in my search. Can you please double check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37528, 37892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37528 [Bug 37528] Using borrowerRelationship while guarantor relationship is unchecked from BorrowerMandatoryField results in error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37892 [Bug 37892] Patron category 'can be a guarantee' means that same category cannot be a guarantor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #19)
I pushed some other relationship related patches today, so I tried to double check especially carefully here.
I notice that we still have this line:
koha-tmpl/intranet-tmpl/prog/js/members.js: var guarantor_relationship = $('#relationship').val();
But you rename the id to special_relationship and I couldn't spot an id with relationship any more in my search. Can you please double check?
There is an id "relationship" in memberentrygen.tt. It was added in these patches. Id "special_character" is used auth-finder-search.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emmi Takkinen from comment #20)
(In reply to Katrin Fischer from comment #19)
I pushed some other relationship related patches today, so I tried to double check especially carefully here.
I notice that we still have this line:
koha-tmpl/intranet-tmpl/prog/js/members.js: var guarantor_relationship = $('#relationship').val();
But you rename the id to special_relationship and I couldn't spot an id with relationship any more in my search. Can you please double check?
There is an id "relationship" in memberentrygen.tt. It was added in these patches. Id "special_character" is used auth-finder-search.inc.
Thanks Emmi, I have missed that, but better safe than sorry :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |release-notes-needed --- Comment #24 from David Nind <david@davidnind.com> --- Could you please add a release note? I tried to get my head around this - what the problem is and how it is fixed (not technically, but what the effect is), but I think I need more coffee! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds "relationship" id release notes| |to memberentrygen.tt so we | |can e.g. use it as selector | |in IntranetUserJS. It also | |removes code which forced | |guarantor relationship to | |be empty when patron | |guarantor is selected. --- Comment #25 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I added release notes but I'm unsure if it's clear enough :D Feel free to modify it if needed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the|This adds "relationship" id |This fixes the patron entry release notes|to memberentrygen.tt so we |and edit form |can e.g. use it as selector |(memberentrygen.tt) to add |in IntranetUserJS. It also |a missing id "relationship" |removes code which forced |to the patron guarantor |guarantor relationship to |relationship dropdown list |be empty when patron |field (so this can be used |guarantor is selected. |as a selector in | |IntranetUserJS). | | | |It also | |fixes an issue when adding | |a patron guarantor to a | |patron that already has a | |non-patron guarantor - this | |would incorrectly set the | |non-patron guarantor | |relationship field to | |empty. --- Comment #26 from David Nind <david@davidnind.com> --- (In reply to Emmi Takkinen from comment #25)
I added release notes but I'm unsure if it's clear enough :D Feel free to modify it if needed :)
Rhanks Emmi! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Bug 31470 depends on bug 37892, which changed state. Bug 37892 Summary: Patron category 'can be a guarantee' means that same category cannot be a guarantor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37892 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #27 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #28 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org