[Bug 39464] New: Z39.50 Search results not highlighting grey rows in yellow when previewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Bug ID: 39464 Summary: Z39.50 Search results not highlighting grey rows in yellow when previewing Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: heather@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When previewing Z39.50 search results in the Cataloging module, the yellow highlighting only applies to white rows, grey rows. This highlighting is very helpful for staff to identify exactly which record they are previewing in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |Templates |Servers | Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Also true of Administration - Circulation and fine rules, should also be true of Administration - Item search fields, Mana report and subscription search results, and maybe others, since they all have the selector ".highlighted-row, .highlighted-row td" fighting for specificity with "tbody tr:nth-child(odd):not(.dtrg-group, .active, .ok) td:not(.bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary)" which is... rather specific. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Not (currently) item search fields, because bug 39477 keeps it from showing for any row, not just the grey rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- And it's clownshoes all the way down. Circulation and fine rules doesn't set .highlighted-row on its <tr>, it sets it on every <td> in the <tr>, so not only does the tr:nth-child(odd):not() need to include .highlighted-row, the td:not() needs to as well. I was going to just write a patch and try to sell a test plan including only the uses I knew how to get to, but since those three are all broken in different ways, I think this needs someone who knows how to write a test plan that gets to mana-report-search-result.inc and mana-subscription-search-result.inc and subscription-detail.tt as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Phil Ringnalda from comment #3)
And it's clownshoes all the way down.
I guess that makes me the clown! Cool. Cool cool cool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- A surprising fact about clown shoes is that they are just normal shoes from the inside, so you don't necessarily know you're wearing them until you get up and try to walk around. Or so I've heard. In a previous project where we used the term constantly, I thought about buying a pair for a profile picture, but another surprising fact about them is that they are jaw-droppingly expensive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I'll be more direct: Calling someone else's code "clown shoes" is rude and uncalled for. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Please accept my apology for the unwarranted and unintended insult. While at Mozilla it's a term of art for a particular sort of cascading breakage, I should have known both before and immediately afterward that since nobody involved in Koha uses it, it wouldn't be seen that way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39556 [Bug 39556] mana-test.koha-community.org not working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39556 Depends on|39556 | --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Not blocking on testing Mana. The same patch does fix things for it, but testing it requires too many gyrations. Mana uses it to highlight entities with between 5 and 10 comments. For reports, comments aren't actually implemented, unless you submit them directly through the API. mana-kb currently has comments on 4 of its 1330 reports, none with 5-10 comments. For serials, there are comments on 26 of the 11810 subscription entities, 2 of which have between 5 and 10 comments (all test or joke comments), but because the comments column isn't filled by Serials - Search on Mana, actually seeing them requires triggering an apparently intermittent bug where you create a new subscription which will find a match on Mana, on the Frequency page click the Show Mana results link, and then wait for the one matching result displayed in the popup dialog to be replaced by every subscription on Mana, giving you a table where you can sort by the comments column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39556 [Bug 39556] mana-test.koha-community.org not working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 180890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180890&action=edit Bug 39464: Grey rows in tables not highlighting in yellow when they should Because the CSS rule for turning odd-numbered rows grey is highly-specific (tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the .highlighted-row, .highlighted-row td rule that some tables use to turn the background of a currently-selected row yellow, so highlighted-row needs to be added to the lists of not(). Test plan: 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like Author smith which will return at least two results. 2. On an even-numbered row with a white background, click MARC and note that the row is given a yellow background (either by increasing the size of the popup to peer around the preview, or by closing the preview, since the highlight persists). 3. On an odd-numbered row with a grey background, click MARC and note that the row isn't given a yellow background 4. Administration - Circulation and fine rules, if you don't already have at least two rules add one by just changing the Patron category in the edit row and Save 5. On a row with a white background, click Edit and note that the background for that row is yellow 6. On a row with a grey background, click Edit and note that the background remains grey, not yellow 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build CSS and JS), clear browser cache or shift+Reload the page 8. Repeat steps 1-6, but this time note that you get the same yellow highlighted background for both odd and even rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180890|0 |1 is obsolete| | --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180895&action=edit Bug 39464: Grey rows in tables not highlighting in yellow when they should Because the CSS rule for turning odd-numbered rows grey is highly-specific (tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the .highlighted-row, .highlighted-row td rule that some tables use to turn the background of a currently-selected row yellow, so highlighted-row needs to be added to the lists of not(). Test plan: 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like Author smith which will return at least two results. 2. On an even-numbered row with a white background, click MARC and note that the row is given a yellow background (either by increasing the size of the popup to peer around the preview, or by closing the preview, since the highlight persists). 3. On an odd-numbered row with a grey background, click MARC and note that the row isn't given a yellow background 4. Administration - Circulation and fine rules, if you don't already have at least two rules add one by just changing the Patron category in the edit row and Save 5. On a row with a white background, click Edit and note that the background for that row is yellow 6. On a row with a grey background, click Edit and note that the background remains grey, not yellow 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build CSS and JS), clear browser cache or shift+Reload the page 8. Repeat steps 1-6, but this time note that you get the same yellow highlighted background for both odd and even rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180895|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 181219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181219&action=edit Bug 39464: Grey rows in tables not highlighting in yellow when they should Because the CSS rule for turning odd-numbered rows grey is highly-specific (tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the .highlighted-row, .highlighted-row td rule that some tables use to turn the background of a currently-selected row yellow, so highlighted-row needs to be added to the lists of not(). Test plan: 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like Author smith which will return at least two results. 2. On an even-numbered row with a white background, click MARC and note that the row is given a yellow background (either by increasing the size of the popup to peer around the preview, or by closing the preview, since the highlight persists). 3. On an odd-numbered row with a grey background, click MARC and note that the row isn't given a yellow background 4. Administration - Circulation and fine rules, if you don't already have at least two rules add one by just changing the Patron category in the edit row and Save 5. On a row with a white background, click Edit and note that the background for that row is yellow 6. On a row with a grey background, click Edit and note that the background remains grey, not yellow 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build CSS and JS), clear browser cache or shift+Reload the page 8. Repeat steps 1-6, but this time note that you get the same yellow highlighted background for both odd and even rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- Adding my sign-off - maybe Magnus's can count as QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181219|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181689&action=edit Bug 39464: Grey rows in tables not highlighting in yellow when they should Because the CSS rule for turning odd-numbered rows grey is highly-specific (tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the .highlighted-row, .highlighted-row td rule that some tables use to turn the background of a currently-selected row yellow, so highlighted-row needs to be added to the lists of not(). Test plan: 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like Author smith which will return at least two results. 2. On an even-numbered row with a white background, click MARC and note that the row is given a yellow background (either by increasing the size of the popup to peer around the preview, or by closing the preview, since the highlight persists). 3. On an odd-numbered row with a grey background, click MARC and note that the row isn't given a yellow background 4. Administration - Circulation and fine rules, if you don't already have at least two rules add one by just changing the Patron category in the edit row and Save 5. On a row with a white background, click Edit and note that the background for that row is yellow 6. On a row with a grey background, click Edit and note that the background remains grey, not yellow 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build CSS and JS), clear browser cache or shift+Reload the page 8. Repeat steps 1-6, but this time note that you get the same yellow highlighted background for both odd and even rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Eric Swenson <eric@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #15 from Eric Swenson <eric@bywatersolutions.com> --- Could this be backported into 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #18 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org