[Bug 19865] New: Side scroll bar in z39.50 MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Bug ID: 19865 Summary: Side scroll bar in z39.50 MARC view Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: jesse@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 70065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70065&action=edit ScreenShot Prior to the 17.05 upgrade when you did a z39.50 search and then viewed the MARC record prior to import, a side scroll bar would appear at the bottom of the window, however, in 17.05 you have to scroll to the bottom of the window before the side scroll bar appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128573&action=edit Bug 19865: Add back horizontal scrollbar to cat_z3950_search To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Regenrate the CSS files ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 7. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 8. It's not a bad idea to test in multiple browsers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Since this change affects only one page and there is already some inline CSS on that page I think it's better to add it to the template and not the global SCSS file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129677&action=edit Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129677|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129695&action=edit Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like the acquisition view needs something for the scroll bar as well: https://snipboard.io/XpC3IS.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129695|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129905&action=edit Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
Looks like the acquisition view needs something for the scroll bar as well: https://snipboard.io/XpC3IS.jpg
Yes, I have filed Bug 29961 and will do it there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29961 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Makes the horizontal scroll release notes| |bar of the MARC preview | |modal on | |cataloguing/z3950_search.tt | |always visible for an | |easier user experience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org