[Bug 29895] New: Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Bug ID: 29895 Summary: Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart+koha@gmail.com Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: 1. get into basket, go find some biblio (i.e. press the "🧺 Add order" button on some biblio) and get into adding items to basket interface, smth /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=233 2. press [Add multiple items] button st get the next interface elements with input for the number of items and the [Add] button. 3. add a few, 2 items, by pressing the [Add] button. 4. the modal will blink and 2 items added. 5. Extra interface with "number of items to add" and [Add] button gone, only three buttons again: [Add item] [Clear] [Add multiple items] . 6. but now if to press [Add multiple items] - nothing happens. Looks like the item lost its listener or not mapped to listener when recreated (if so). It seems the issue in koha-tmpl/intranet-tmpl/prog/js/additem.js. One side observation: - if after this to press "Add item" button and add single item, then "Add multiple items" starts to work for one time again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #1 from Andrew Nugged <nugged@gmail.com> --- Also there typo with quoting in the same additem.js file, notice: name=buttonAddMulti" in line 187: + '<input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + __("Add") + '" />' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129533&action=edit Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129533|0 |1 is obsolete| | --- Comment #3 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Created attachment 129572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129572&action=edit Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129572|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130023&action=edit Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org