[Bug 16620] New: Translatability: Fix problem with isolated word "please" in auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Bug ID: 16620 Summary: Translatability: Fix problem with isolated word "please" in auth.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt, a tag-isolated word "please" leads to translation problems (syntax in different languages). Line 81: please <a href="[% casServerUrl %]">click here to login</a>.<p> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 51921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51921&action=edit Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that in line 81 the word "please" is inside the a-tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Marc Véron <veron@veron.ch> --- Oh, there are more syntax problems... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51921|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 51922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51922&action=edit Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Same problem exists in OPAC. Maybe do it in one go? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Srdjan Jankovic from comment #4)
Same problem exists in OPAC. Maybe do it in one go?
Ah, yes. opac-auth.tt lines 90 and following. This could go to Bug 16540: Translatability in opac-auth.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16540 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51922|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 51956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51956&action=edit [SIGNED-OFF] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51956|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52155&action=edit Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org