[Bug 16613] New: MARC 09X Field Help Links are Broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Bug ID: 16613 Summary: MARC 09X Field Help Links are Broken Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 51885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51885&action=edit git-created patch, adds 2 lines of JS The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Steps to recreate: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window - taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html Since there's already an if-else clause for 9XX tag documentation, I thought this deserved an exception too. Attached is a patch which links the 09X help fields to the link referenced above. Let me know if I'm not following the right guidelines, I'm not used to submitting patches like this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #51885|application/mbox |text/plain mime type| | Attachment #51885|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |ephetteplace@cca.edu Status|NEW |Needs Signoff --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Hi Eric, I took the liberties of: 1 - Assigning the bug to you 2 - Marking the attachment as a patch 3 - Marking the bug as 'Needs Signoff' I can help you with how to do any/all of these things if you have any questions. Congrats on submitting your first patch! -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 51889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51889&action=edit fix MARC 09X help links cataloging module UI https://bugs.koha-community.org/show_bug.cgi?id=16613 Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- Awesome, thanks for the quick turnaround! Really excited to start working with Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51885|0 |1 is obsolete| | Attachment #51889|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52235&action=edit Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52235|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52237&action=edit Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|16.05 |unspecified --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Eric, Have a loot at our wiki page https://wiki.koha-community.org/wiki/SubmitingAPatch for your next patch :) Thanks for your fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks phette! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org