[Bug 22375] New: Due dates should be formatted consistantly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Bug ID: 22375 Summary: Due dates should be formatted consistantly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Now we have some due dates formatted as datetime, and some shows time part only when it is hourly loan (as_due_date = 1 param of KohaDates filter is used) This should be same for all due dates across whole system, as_due_date should be used everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17236 [Bug 17236] Add minute and hours to last checked out item display for hourly loans -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85331&action=edit Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) batch checkouts 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Bug 22375 depends on bug 17236, which changed state. Bug 17236 Summary: Add minute and hours to last checked out item display for hourly loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17236 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #1) Everything looks like it's working well except this page:
3) batch checkouts
I get an error on that page.
Note: I suspect the moremember-receipt.tt template is not used anymore
Yes, which is causing a conflict when apply this patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Due dates should be |Due dates should be |formatted consistantly |formatted consistently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85331|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149722&action=edit Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149723&action=edit Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #2)
(In reply to Josef Moravec from comment #1)
Everything looks like it's working well except this page:
3) batch checkouts
I get an error on that page.
This file is no longer included in the patch set (already fixed).
Note: I suspect the moremember-receipt.tt template is not used anymore
Yes, which is causing a conflict when apply this patch!
This file has been deleted meanwhile and is also not included. I found some more and wrote up a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149722|0 |1 is obsolete| | Attachment #149723|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150655&action=edit Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150656&action=edit Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch - removed 'fda' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Jonathan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 [Bug 33888] Overdue fines not displayed branchoverdues.pl error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Merge conflicts in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org