[Bug 33622] New: Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Bug ID: 33622 Summary: Notice content does not show on default tab if TranslateNotices enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org This was first noticed in 22.11 but can confirm it happens in main too. To reproduce: 1. Restart services 2. Go to Koha Administration -> Global system preferences and enable the TranslateNotices system preference 3. Go to Tools -> Notices & slips 4. Go to edit any notice i.e. ACCOUNTS_SUMMARY 5. Expand the Email section of the Default tab. Confirm there is no content in the notice --> BUG 6. Click on the next language tab, then expand the Email section. It is probably empty if you've only just enabled TranslateNotices and have not set up specific notices for your installed languages so this is fine. 7. Go back to the Default tab and expand the Email section. Confirm the content now shows for the notice It should show upon first expand of Email section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also confirmed in master. Wonder if this could have something to do with the work on tabs? Adding Owen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (I'm using main in place of master as much as possible hehe) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right - I think we also decided to switch, but haven't yet figured out the steps and timing. I mostly wanted to help this along saying I can see it too and I'd also really like to see it fixed - it could cause a bit of a panic when people think they lost their content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32912 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just checked our 22.11.03 instance and it still appears to be working ok there. Maybe another clue. Bug 32912 could be a possible candidate. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32912 [Bug 32912] Use template wrapper for notices tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150529&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150529|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 150533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150533&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To replicate the issue (note: ACCOUNTS_SUMMARY has no email notice, DUEDGST does have an email notice) I had to install another language (other than just having the Default and English (en) tabs): - Install another language: koha-translate install fr-CA - Enable the language: Administration > System preferences > I18N/L10N > language > Français (fr-CA) - Enable the TranslateNotices system preference - Edit the DUEDGST notice - It opens on the Default tab: expand the Email notice --> it is blank - Click on the tabs for English (en) and Français (fr-CA), and expand the email notice section (should be blank, unless you've added translations already) - Click back on the Default tab and expand the Email notice --> it is now not blank - Refreshing the page resets things, so you can then replicate the issue again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150533|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150535&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org