http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #1)

Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere).

I am not sure about that.

From http://multimedia.bnf.fr/unimarcb_trad/B123-6-2010.pdf, $ij are declinaison and $fg are coordinate. Moreover the default value should be '00' not '', isn't it?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- http://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_123_u... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33245|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33289&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #7)

(In reply to Jonathan Druart from comment #2)

...

Moreover the default value should be '00' not '', isn't it?

Corrected.

1 character is still missing. "A celestial chart with an angular scale, with declination -16° to -49°" is $i-0160000$j-0490000 With the patch, I get $i-016000$j-049000 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)

(In reply to M. de Rooy from comment #7)

...

(In reply to Jonathan Druart from comment #2)

...

Moreover the default value should be '00' not '', isn't it?

Corrected.

1 character is still missing.

"A celestial chart with an angular scale, with declination -16° to -49°" is $i-0160000$j-0490000

With the patch, I get $i-016000$j-049000

Thanks for testing. Fixed a dumb typo: f3 = f3.substring(f2.length-2); f2->f3 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)

What means "Degree (complete with 0):"? Does it should be 000 for degree and 00 for the 2 others?

I just copied this from the existing unimarc_field_123g template. It actually means left padding with zeroes. I agree that this text is confusing. According to the specs, it is plus or minus followed by 3-2-2 chars (total 8). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33292|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33299&action=edit Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33299|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33347&action=edit [PASSED QA] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Checked plugin in a UNIMARC installation. -- You are receiving this mail because: You are watching all bug changes.