[Bug 11817] New: Staff client next/previous browse JavaScript interferes with other JS functions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Bug ID: 11817 Summary: Staff client next/previous browse JavaScript interferes with other JS functions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The JavaScript which builds the staff client detail page's next/previous links uses a selector which is too broad: Line 79: $('a[href*="biblionumber="]').click(function (ev) This can cause problems with other click events on the page. To reproduce the error: 1. Log into Koha as a user who has cataloging permissions. 2. Search for a title. 3. View the detail page for a title which has items attached. 4. From the Edit menu choose "Delete record." At this point you should see an alert warning you that the title cannot be deleted because it has items attached. However, the page will still proceed to the delete page (and an error message will appear). The problem doesn't happen if you navigate directly to a detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I suggest to remove the browser feature from cataloging module. It works perfectly for catalogue module, but for cataloging module, I think it can cause too much bugs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolin SOMERS from comment #1)
I suggest to remove the browser feature from cataloging module.
What do you mean by the cataloging module? Do you mean the staff client? Can you please point out the bugs you know of? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10404 --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Owen Leonard from comment #2)
(In reply to Fridolin SOMERS from comment #1)
I suggest to remove the browser feature from cataloging module.
What do you mean by the cataloging module? Do you mean the staff client? Can you please point out the bugs you know of?
No I mean the pages additem and addbiblio, they have been modified by -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Owen Leonard from comment #2)
(In reply to Fridolin SOMERS from comment #1)
I suggest to remove the browser feature from cataloging module.
What do you mean by the cataloging module? Do you mean the staff client? Can you please point out the bugs you know of?
No I mean the pages additem and addbiblio, they have been modified by Bug 10404. And it is for them that this code exists : $('a[href*="biblionumber="]').click(function (ev) If only catalogue module is used, we could change this code to : $('a[href*="detail.pl?biblionumber="]').click(function (ev) By the way, addbiblio has been changed but the browser does not appear in page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- According to Jared the addbiblio and additem pages are modified for two cases: - Search for a title -> View a title -> Edit that title -> Save the record -> Redirected to title view: Next/previous links are still present - Search for a title -> View a title -> Edit items -> Next/previous links are visible on the edit item screen. The only bug that I see here is that the "return to results" link from the item edit screen isn't working for me. Fridolin are there other bugs you see? You must be seeing serious problems if you're recommending that the feature be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Owen Leonard from comment #5)
The only bug that I see here is that the "return to results" link from the item edit screen isn't working for me. The most important problem is the deletion of a record you reported in first comment. It's a big problem no ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12261 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #7 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- When one clicks on "delete record", if the record has items attached, the javascript alert is displayed very briefly, then skipped, and Koha proceeds to the deletebiblio page. The record will not be deleted but we end up with a disgraceful full page message: ERROR when DELETING BIBLIO 433 : This Biblio has items attached, please delete them first before deleting this biblio While there doesn't seem to be a risk of accidentally deleting data, it would be good to fix this behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 --- Comment #8 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- I spoke a little too fast here : this seems to be fixed in master. But i also can't see the link back to results right now, so this might be linked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12378 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12821 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Is this problem still exist on master? It seems that bug 11821 corrected it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library@stas.org --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 12378 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I agree with Jonathan -- Bug 11821 seems to have fixed this bug. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org