[Bug 31861] New: Table controls on checkouts table are buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Bug ID: 31861 Summary: Table controls on checkouts table are buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Created attachment 142088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142088&action=edit Screenshot of checkouts table The table controls to export, print and change columns on the checkouts table in patron account look much different to the table controls on other tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Depends on| |31754 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 [Bug 31754] Improve appearance of behavior of DataTables controls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142192&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142192|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142198&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142198|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142359&action=edit Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Resolves issue found, improves consistency and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. there is a regression here.. The 'Clear filter' link becomes a button again after this patch.. and causes page jiggle.. this seems to undo something fixed in bug 31754 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142495&action=edit Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142495|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142497&action=edit Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for quick follow-up.. PQA now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 [Bug 31962] Standardize tooltips on datatable controls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Bug 31861 depends on bug 31754, which changed state. Bug 31754 Summary: Improve appearance of behavior of DataTables controls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org