[Bug 31886] New: No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Bug ID: 31886 Summary: No side menu when searching for syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 And also something weird at the bottom, see https://snipboard.io/PRgUln.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 [Bug 31758] Add 'page-section' to system preferences page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I think it is because of 'LINE.is_group_title'. And that has to do with how we format the .pref yaml files. This seems to happen when you search brings up i18n_l10n or serial system prefs. If we fix the YAML, I think we'll fix the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142289&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142289|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142335&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well spotted Lucas... I wonder if instead of repeating the title we should pick a appropriate subsection group title instead. Perhaps 'Global' or 'Features' or something like that.. So something like? * Serials - Features * I18N - Global -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Side note... it feels a bit weird that the 'You search for: TERM' is an H2 to me.. it means we end up with 'H1 > H2 > H2' and it doesn't stand out very well.. I'd be tempted to switch it to a span of some sort with it's own slightly different formatting? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #4)
Well spotted Lucas... I wonder if instead of repeating the title we should pick a appropriate subsection group title instead.
Perhaps 'Global' or 'Features' or something like that..
So something like?
* Serials - Features * I18N - Global
This seems reasonable to me, I'll make that change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just moving out of queue until it bounces back with the follow-up :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 [Bug 31917] Headings don't seem quite right for system preference search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142335|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142402&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142402|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142405&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142405|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142406&action=edit Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seems there is still some invalid YAML: https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/cons... Weird that only one build fails about this. Failing files touched by this ticket and bug 31952 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #12)
It seems there is still some invalid YAML: https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/ consoleText
Weird that only one build fails about this.
Failing files touched by this ticket and bug 31952
Victor, Should we file a new bug for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32065 Depends on|32065 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065 [Bug 32065] Invalid for some system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Ok, I wasn't sure if a follow-up could be made in the existing tickets: Bug 32065 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 [Bug 32126] Adding item search fields is broken - can't add more than one field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 [Bug 32126] Adding item search fields is broken - can't add more than one field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Bug 31886 depends on bug 31758, which changed state. Bug 31758 Summary: Add 'page-section' to system preferences page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org