http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Medium patch Assignee|kyle.m.hall@gmail.com |jonathan.druart@biblibre.co | |m QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- In France a "quitus" (translated here by "discharge") is needed if you want to register in a state-owned company (library or university). It means the patron don't have any document in his possession / is in order with his previous library. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Do you have the xhtml2pdf command available? It is provided by the python-pisa package. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm still having problems even after installing that package: [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] Traceback (most recent call last):, referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] File "/usr/bin/xhtml2pdf", line 5, in <module>, referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] from pkg_resources import load_entry_point, referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] ImportError: No module named pkg_resources, referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] tar: Removing leading `/' from member names, referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 [Fri Feb 15 11:56:37 2013] [error] [client 192.168.1.30] [Fri Feb 15 11:56:37 2013] discharge.pl: readline() on unopened filehandle at /home/koha/kohaclone/C4/Discharges.pm line 68., referer: http://staff.kohadev/cgi-bin/koha/members/discharge.pl?borrowernumber=18 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Pierre Angot <tredok.pierre@gmail.com> --- I have note tested this problem. So failed qa -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #11 from Pierre Angot <tredok.pierre@gmail.com> --- In a sandbox : - pro : when I click on the discharges button, nothing happen. - opac : there is an error "could not been sent" Is there a problem with sandbox ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am worried about libraries taking this not seriously or just missing that they should be doing that: - For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes Could we provide a standard path and a .htaccess file? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16622|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16935&action=edit Bug 8007: Discharge management At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and download discharges already generated. Requirements: aptitude install python-pisa New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge - dischargePath: Sets the upload path for the generated discharges - dischargeWebPath: Sets the upload path starting from documentroot for the generated discharges New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Fill the syspref dischargePath (e.g. /home/koha/src/koha-tmpl/discharges) - Fill the syspref dischargeWebPath (e.g. /discharges) - For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes and change the rights: sudo chown www-data:www-data /home/koha/src/koha-tmpl/discharges - Check that a new tab appears in the patron page (intranet and opac) - Check that the discharge cannot be generated if the patron has issues. - Check that the patron can request a discharge from it's opac area. - The request is a mail sent via the sendmail command - Generate the discharge from the intranet - Try to download it (from the opac and the intranet) Sponsored-by: SCD Limoges -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #16 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #14)

(In reply to comment #13)

...

I am worried about libraries taking this not seriously or just missing that they should be doing that:

- For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes

Could we provide a standard path and a .htaccess file?

I don't think so. This file should be placed in the directory pointed out by the syspref dischargePath. Moreover the file should have specific rights (www-data). We can do that in a patch.

I complete the RFC page on the wiki.

This can be done! My first iteration of the plugins feature did this. You'll need to modify the installation files to create var/lib/discharges or such, and put the .htaccess file there. You can check out early versions of the plugins patch to see how to do it. The .htaccess I believe will need to go somewhere in skel skel/var/lib/koha/discharges, and I think that would give a standard path. If you want to have a nonstandard path, just symlink var/lib/discharges to your nonstandard path. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17485&action=edit Bug 8007: Add a discharges example file -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- I don't think it applies cleanly. mtompset@ubuntu:~/kohaclone2$ git bz apply 8007 Bug 8007 - Discharge management 17484 - Bug 8007: Discharge management 17485 - Bug 8007: Add a discharges example file Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8007: Discharge management Using index info to reconstruct a base tree... <stdin>:587: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/gather_print_notices.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/de-DE/mandatory/sample_notices.sql Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Failed to merge in the changes. Patch failed at 0001 Bug 8007: Discharge management When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8007-Discharge-management-8LjEoI.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17484|0 |1 is obsolete| | Attachment #17485|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21394&action=edit Bug 8007: Discharge management At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and download discharges already generated. Requirements: aptitude install python-pisa New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge - dischargePath: Sets the upload path for the generated discharges - dischargeWebPath: Sets the upload path starting from documentroot for the generated discharges New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Fill the syspref dischargePath (e.g. /home/koha/src/koha-tmpl/discharges) - Fill the syspref dischargeWebPath (e.g. /discharges) - For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes and change the rights: sudo chown www-data:www-data /home/koha/src/koha-tmpl/discharges - Check that a new tab appears in the patron page (intranet and opac) - Check that the discharge cannot be generated if the patron has issues. - Check that the patron can request a discharge from it's opac area. - The request is a mail sent via the sendmail command - Generate the discharge from the intranet - Try to download it (from the opac and the intranet) Sponsored-by: SCD Limoges -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21396&action=edit Bug 8007: QA Followup Change GPL version to v3+. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Testing this. It's a good feature. Our university students need to get a 'discharge' certificate (we call it "libre deuda"). The best we can do with Koha is print a circulation slip that shows no items on loan. Test 1) Patches applied, a few touchs on updatedatabase.pl (using CheckVersion($DBversion) instead of C4::Context->preference("Version") < TransformToNum($DBversion), add Bug number to update message) 2) Enabled sysprefs, created dir, etc. 3) OPAC, patron view Discarged tab (I think it could be "my discharge" or "discharges" with lower case for consistency) 4) OPAC, patron with an issue can't generate discharge, but the message do not state that fact, only tells that can´t be generated 5) OPAC, patron without issue can request discharge, mail to library sent 6) STAFF, Discharge tab is Upercase, in sync with others 7) STAFF, trying to generate discharge for patron with issue states that fact. 8) STAFF, patron without issue... This is when I run into problems. Staff interface only tells "An error has ..." Files are created!! ( kohaclone$ ls -l ../kohadev/discharges/52 total 8 -rw-r--r-- 1 www-data www-data 668 sep 29 16:50 discharge-2013-09-29.html -rw-r--r-- 1 www-data www-data 2801 sep 29 16:50 discharge-2013-09-29.pdf ) Log shows this: discharge.pl: readline() on unopened filehandle at /home/bgkriegel/kohaclone/C4/Discharges.pm line 68., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/members/discharge.pl?borr... Looking into the code (line 68) I fund that you read files in user dir like my $pdf_path = qq{$dischargePath/$borrowernumber/*.pdf}; my @files = <$pdf_path>; I can replicate the error message using perl -e 'use Modern::Perl; my $p = qq{52/*.pdf}; my @f = <$p>;' readline() on unopened filehandle at -e line 1. [with or without files] So, all stops trying to read files. I think this is a bug, or perhaps I'm doing something wrong. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21660&action=edit Bug 8007: Followup: fix read dir error This patch fixes: - an error on reading the discharges directory - the parameter sent to CancelReserves (API has been changed) - the parameters sent to output_pref (API has been changed) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21394|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21674&action=edit [SIGNED-OFF] Bug 8007: Discharge management At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and download discharges already generated. Requirements: aptitude install python-pisa New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge - dischargePath: Sets the upload path for the generated discharges - dischargeWebPath: Sets the upload path starting from documentroot for the generated discharges New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Fill the syspref dischargePath (e.g. /home/koha/src/koha-tmpl/discharges) - Fill the syspref dischargeWebPath (e.g. /discharges) - For a security reason create a .htaccess in your dischargePath with the following content: Options -Indexes and change the rights: sudo chown www-data:www-data /home/koha/src/koha-tmpl/discharges - Check that a new tab appears in the patron page (intranet and opac) - Check that the discharge cannot be generated if the patron has issues. - Check that the patron can request a discharge from it's opac area. - The request is a mail sent via the sendmail command - Generate the discharge from the intranet - Try to download it (from the opac and the intranet) Sponsored-by: SCD Limoges Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well. No koha-qa errors Solved merge conflict in updatedatabase.pl Test following test plan 1) enable sysprefs, put discharges dir somewhere in filesystem, with correct permissions, for webpath I did a symlink to koha-tmpl 2) created .htacces as example 3) new tab appears on user OPAC 4) patron can't request discharge with items on loan 5) patron can request dischrage without issues, email sent correct, 6) Discharge generated from intranet, also check that can't be generated if patron has issues 7) Download correct from OPAC and STAFF -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21396|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21676&action=edit [SIGNED-OFF] Bug 8007: QA Followup Change GPL version to v3+. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21660|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21678&action=edit [SIGNED-OFF] Bug 8007: Followup: fix read dir error This patch fixes: - an error on reading the discharges directory - the parameter sent to CancelReserves (API has been changed) - the parameters sent to output_pref (API has been changed) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Reading files problem solved. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #28)

Worked! :)

Last question: On a dev install, koha-tmpl is accesible from oapc and staff, but on a packages/tar install DocumentRoot for opac and staff do not overlap.

opac -> DocumentRoot /usr/share/koha/opac/htdocs staff -> DocumentRoot /usr/share/koha/intranet/htdocs

I solved this doing a symlink of discharges dir to both htdocs but this must be stated on instructions

I think this feature should be installed/configured by a sysadmin. Paths have to be adapted depending each installation/preference.

Do you plan some followup to remove these files?

No, currently I don't have followups for this feature. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am sorry, but the patch does no longer apply. Some questions I had from looking at the code/patches: 1) Can we ensure that patrons can't access discharge notices from other patrons by guessing the file name? I know this would be a rewrite, but keep wondering if this could be done dynamically and without storing files. Like have a flag that the user is allowed to download a discharge notice with date x and then generate the pdf file dynamically. 2) The email send to the library is not translatable. Instead of sending an email to the library, it could show up on the dashboard. 3) Can you provide unit tests for the new module and routines please? 4) I think this bit will have to be changed for the new handling of debarments/restrictions: + # (this is quite ugly, but this is how borrowers seems to be permanently debarred) + # FIXME: Perl strings are not translatable atm, so comment is written in english + C4::Members::DebarMember($borrowernumber, '9999-12-31', "Discharge generated by $librarianname on $date"); 5) Question: Which cronjobs are needed for this? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21674|0 |1 is obsolete| | Attachment #21675|0 |1 is obsolete| | Attachment #21676|0 |1 is obsolete| | Attachment #21677|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24023&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24025&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24027&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- I would recommend ditching the DataObject::Discharge and go with directly using DBIC with Koha::Database. It seems like an unnecessary layer of overhead. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #44 from Galen Charlton <gmcharlt@gmail.com> --- Jonathan: first, let me thank you for engaging with DBIC. (In reply to Kyle M Hall from comment #43)

(In reply to Chris Cormack from comment #41)

...

I have to say, I am really not a fan of the ::DataObject:: and ::Service:: idea. I may be overruled on that I guess. I'd prefer a Discharge class I think.

I believe in our developer discussions at KohaCon13 the basic consensus was that the DataObject layer was not needed and was just over-complicating everything and adding unnecessary overhead ( it was only in our initial designs to join biblio and biblioitems virtually ).

I agree. There are *some* specific cases, most notably bibs, where an intermediate class might be useful to deal with legacy defects in the current data model, and some cases where complicated business logic suggests a container class, but I am not in favor of creating DataObject classes or the like automatically. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #46 from David Cook <dcook@prosentient.com.au> --- I'm even all right with benign dictatorship saying how it's going to be from here on out, but it would be good to have firm guidelines in place... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24024|0 |1 is obsolete| | --- Comment #48 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 30532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30532&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24026|0 |1 is obsolete| | --- Comment #50 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 30534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30534&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module HTML::HTMLDoc New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #52 from Yohann Dufour <yohann.dufour@biblibre.com> --- I have refactored the work of Jonathan in order to adapt it to the different comments I have read on this bug report. I have tried to find the best compromise between organization, heaviness and simplicity to finally integrate this improvement in Koha. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #54 from Yohann Dufour <yohann.dufour@biblibre.com> --- In order to be able to generate PDF from HTML with Perl, you need to install first the Perl module HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #56 from Paul Poulain <paul.poulain@biblibre.com> --- Even if this enhancement is highly usefull for a end-of-year school time and we are at the beginning of it, it's a very valuable one. Bernardo, any chance you could test it again and sign-off ? Chris/Katrin/Galen/Kyle, comments from the QA POV ? Jonathan has risen a topic about DBIx::Class on koha-devel, comments welcomed. I would really like to have a positive issue on this matter, to know how to write code, not only to know how to not write code ! (hint: chris, katrin, Jonathan, Bernardo, Tomas and I will be in Cordoba, -not kyle, I don't know for Galen-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34035&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34037&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module HTML::HTMLDoc New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34039&action=edit Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #65 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Would it be possible to use PDF::fromHTML? (http://search.cpan.org/~autrijus/PDF-FromHTML-0.12/lib/PDF/FromHTML.pm) With that we can set correct encoding and font, for example DejaVuSans, and have a decent international support -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34035|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34669&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34037|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34671&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module PDF::FromHTML New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34039|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34673&action=edit Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34675&action=edit Bug 8007: Compatibility with bug 11944 This patch should be applied to work with bug 11944. If you don't have 11944 yet, just don't apply this patch. Note that the line binmode(STDOUT); in pl files is mandatory. It comes from bug 11944 that adds the line binmode( STDOUT, ":utf8" ); in C4::Templates::gettemplate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34668|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36180&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34670|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36182&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34672|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36184&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36186&action=edit Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #83 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #85 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36394&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #87 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36396&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #89 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36398&action=edit Bug 8007: Discharge - Add unit tests Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #91 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36400&action=edit Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Workflow question: After the patron has printed a discharge notice from the OPAC he can go to the library and check out books again, so the discharge would then be invalid. How can we deal with that? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #95 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #94)

I would expect a restriction "Discharged" (similar to manual restricitions).

It would display a message like: Restricted: Patron's account is restricted with the explanation: Discharched

Should work like that (looking at the code). I suspect the updatedb entry was not executed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #96 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- General tests: - discharge a patron as a librarian: ok - ask for a discharge as a patron: ok. For the specific issue of restricting the patron: - in both cases, once the discharge was generated, the patron was restricted with : - Type: Discharge - Comment: <none> - Expiration: Indefinite. Restriction works for me. I'm putting this enh back in Signed-Off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36394|0 |1 is obsolete| | Attachment #36395|0 |1 is obsolete| | Attachment #36396|0 |1 is obsolete| | Attachment #36397|0 |1 is obsolete| | Attachment #36398|0 |1 is obsolete| | Attachment #36399|0 |1 is obsolete| | Attachment #36400|0 |1 is obsolete| | Attachment #36401|0 |1 is obsolete| | --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37029&action=edit [PASSED QA] Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37031&action=edit [PASSED QA] Bug 8007: Discharge - DBIx changes Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37033&action=edit [PASSED QA] Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module PDF::FromHTML New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37035&action=edit [PASSED QA] Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37037&action=edit [PASSED QA] Bug 8007: Compatibility with bug 11944 This patch should be applied to work with bug 11944. If you don't have 11944 yet, just don't apply this patch. Note that the line binmode(STDOUT); in pl files is mandatory. It comes from bug 11944 that adds the line binmode( STDOUT, ":utf8" ); in C4::Templates::gettemplate. Signed-off-by: Lucie <lucie.rousseaux@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #107 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi from comment #106)

Couldn't you just choose a PDF library that is shipped with Debian? :-D

Seconded!

I successfully built both - libpdf-writer-perl - libpdf-fromhtml-perl on Jessie but I need to check with Robin. Maybe he would let me build those. I put this one on hold for a couple days (it works, I like it).

It'll need to build on Wheezy, too. That might be fine, or maybe it won't be. I'll have a look when I get some other people-wanting-dependencies-that-don't-exist issues sorted. I am curious why we need multiple PDF writing things though, is it not possible to standardise around one? (and fair enough if it's not, but I'd like it to be considered before just adding in dependencies.) Tomás: You can build the packages if you like, so long as they would get into debian :) (or, to be honest, if they pass lintian with pedantic=yes and the pkg-perl profile applied, that's usually 90% of the work done right there. It's about time I started scripting more of the deploy process, and someone else doing stuff with it would make that more necessary.)

There's also a new non-Perl dependency python-pisa. It definitely needs to be added to control.in on the koha-deps section for this to be pushed.

Gar. We literally just removed python as a dependency. Like, a couple of weeks ago. Oh well. Unrelated to the packaging, and I'm not sure if this is a problem, but it looks like files are generated as borrnum/borrnum+date.tar.gz, and this is a totally predictable filename. Is this an OK thing to have? Also, should paths be a system preference? Should library staff be able to change the web paths and file paths on the system? That seems like something that is out of the scope of library policy and well into the scope of systems admin, and so defined in koha-conf.xml. My litmus test there is "does it make sense for library staff to be able to change this.", and in a case like this, I contend that it's meaningless. It also makes it harder for installation processes to set it to something that suits the distribution. Actually, the more I think about it, the more of a problem that last part is, as it means there's no way to have a "default works" situation, and there's no way you could expect library staff to fill out a path on the system. Additionally, this should be creating directories under /var/lib/koha/instancename/ as part of koha-create-dirs to put these files, and alias to them in the appropriate apache template. Other misc things: * discharges.pl has no error handling, it just blindly attempts to open a file and send it. What if the file doesn't exist? It looks like you'll then end up with people saving those PDF files that really contain an error message that confuses everyone. * related, there are other places where files are opened and everything is assumed to be OK. Can we stop assuming that everything is going to be OK? It causes too many problems when it's not. Code defensively, handle errors sensibly. * the RFC talks about mailing things, but I can't see in the patches where that happens, does it exist? I was trying to verify it was using the mailqueue, as the RFC implies (but doesn't say) that it doesn't. I'm going to make it failed because there's a good few things in here that need to be considered. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #109 from Robin Sheat <robin@catalyst.net.nz> --- OK, that does address many of my concerns, though I'd like better error checking still. I don't mind adding a dependency like this, it was more a grump about having just got rid of python☺ Will have another proper look tomorrow. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #113 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Feature pushed to master. Thanks Yohann and Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #114 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #112)

FTR:

- It doesn't need python-pisa :-D (this was removed at some point) - The new dependencies for this one are: * libhtml-tidy-perl * libgraphics-colornames-perl * libpdf-fromhtml-perl (build needed) * libpdf-writer-perl (build needed)

I'm a bit confused... It appears that libgraphics-colornames-perl and libpdf-writer-perl are dependencies for libpdf-fromhtml-perl. However, I don't see libhtml-tidy-perl in the code? I notice that Image::Size is a dependency of PDF::FromHtml though. Also, why is PDF::FromHTML marked as not required in the koha_perl_deps.pl? As soon as you log in to Koha on master, you're faced with: "Can't locate PDF/FromHTML.pm in @INC (you may need to install the PDF::FromHTML module)", since Koha::Borrower::Discharge loads on mainpage.pl... Do we just need a follow-up patch for C4::Installer::PerlDependencies to mark it as required? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #116 from Robin Sheat <robin@catalyst.net.nz> --- PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough quality to be a Debian package so is going to take a bit of time to prepare packages for (I'm not willing to take on the technical debt of being a sole maintainer, I'm afraid, so am going to insist that it's ready for debian before I put it into the Koha repo.) Here's the list of errors it produces: http://paste.koha-community.org/86 If you want to make some patches to fix any of this, especially the manpage errors, that would help this process along a whole lot. The git repo is here: ssh://git.debian.org/git/pkg-perl/packages/libpdf-fromhtml-perl.git Tomás, this does mean that master isn't going to be able to be built properly until this is resolved. PS: good practice for anyone who wants to learn about what's needed to package things correctly, which I encourage as then it means less to do for me :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14165 CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #118 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marcel de Rooy from comment #117)

(In reply to Robin Sheat from comment #116)

...

PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough quality to be a Debian package so is going to take a bit of time to prepare packages for (I'm not willing to take on the technical debt of being a sole maintainer, I'm afraid, so am going to insist that it's ready for debian before I put it into the Koha repo.)

If Debian does not like it, why are we using it? Maybe changing the dependency to a better alternative is not that much work?

You can read back the 100+ comments above. I did not find a better alternative, otherwise I would have used it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #120 from Robin Sheat <robin@catalyst.net.nz> --- libpdf-writer-perl is currently in the Debian NEW queue, and in the Koha repository. libpdf-fromhtml-perl is being a more recalcitrant. I'm hoping that by spending some time on it today, I'll succeed it making it build correctly, and if I'm really lucky it'll work in wheezy too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #122 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yay! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14325 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14250 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 [Bug 14250] can generate discharge for patron with fines -- You are receiving this mail because: You are watching all bug changes.