[Bug 14599] New: Saved auth login and password are used in patron creation from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Bug ID: 14599 Summary: Saved auth login and password are used in patron creation from Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. How can it be disabled ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #1 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- This seems like a revival of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8080 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8080 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- When using private navigation in Firefox : In loggin form the loggin is not filled-in automatically and the password is filled-in automatically after choosing a loggin. Then in add patron form, the problem does not occurs. Also, in normal navigation, it is the same behavior if I have more than one loggin registred. The problem seems to be a Firefox behaviour, independently from "autocomplete=off". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|minor |normal --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this could be quite problematic and we should fix it: To test: - Log into Koha, allow the browser to save the password. - Create a new patron. - Verify that your saved password and username have been added to the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-wi... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It seems like this is a known problem, but I haven't found a really good fix yet. One way I found to 'fix' it is adding additional hidden input fields of the password type to the form. As the stackoverflow entry mentions, 3+ password fields on a page keep Firefox from filling them in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I've found using a disabled input between loggin and password disables autocompletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45099&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-wi... I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45099|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 45125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45125&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-wi... I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45125|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45146&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-wi... I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This is not elegant but it works. Note that the problem does not exist with Chromium -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal@bywatersolutions.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 14236 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org