https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- There is a flaw in the design here that I cannot overcome. If a user has saved settings for a table, then sorting is NULL in the db - and if it is NULL you cannot set the sorting. We cannot override the DB from the yaml so I don't know how to correct if a user has already saved the page size for this table (or any in the group) since sort and page are in the same row. We can't set NULL to 'default' because some tables shouldn't have the option and now they would. I am submitting my patch anyways :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 [Bug 38080] Sorting options for holdings table are incorrect -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38107 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Does it mean we could add this "default" to all tables actually? Instead of one bug per table :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 34638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)

Does it mean we could add this "default" to all tables actually? Instead of one bug per table :)

That was the idea, add a general way to add the setting without affecting existing settings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens (kidclamp) from comment #7)

(In reply to Fridolin Somers from comment #4)

...

Looks great.

But I'm confused with default sort order = default. Default of default ?

Maybe we could use 'inherit' like in CSS ? Or 'none'

Some tables have an order built in to the api - items/holdings for example - so we don't want to automatically set this to overwrite.

I think 'default' make sense, none might be a lie.

OK all good :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to David Nind from comment #10)

It doesn't seem to be working correctly for me:

1. I added several more items, and changed the data for items with different library branches, and item types, and checked some items out

2. If I set the default order in the table settings, it seems to choose another column to sort by, for example: . holdings_lastseen ==> sorts by Renewals . holdings_holdingbranch ==> Home library . holdings_itype ==> Current library . holdings_barcode ==> Copy number (had to change the columns to display)

Hmmm, this sounds similar to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568#c66:

3. If StaffDetailItemSelection and/or LocalCoverImages is turned off, the alignment of the drop-down filters for the other columns is offset by 1 for each of the two sysprefs that is disabled Example: StaffDetailItemSelection is enabled; LocalCoverImages is disabled. The first 5 columns are the selection column, Item Type, Current Library, Home Library, Collection. Item Type has a text filter instead of a drop-down. Current Library has a drop-down, but it contains Item Type values (and is thus useless). Home Library has a drop-down containing branch names (but this is presumably still shifted from Current Library) Collection has a drop-down containing branch names (again, useless) ** If the cover images column is hidden, but not disabled by syspref, the offset does not occur.

Which was fixed by commit a767e15c74bd63f4eed51beee982fc5ddd468a02: Fix columns shift when pref are off Is the same thing happening here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Doesn't apply anymore, likely due to Bug 36640 being merged. No sure that it will help with Comment 10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Megan McShane <megan.mcshane@churchofjesuschrist.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |megan.mcshane@churchofjesus | |christ.org --- Comment #14 from Megan McShane <megan.mcshane@churchofjesuschrist.org> --- We would also like to set the default display order through the table settings. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #15 from David Cook <dcook@prosentient.com.au> --- *** Bug 39660 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 --- Comment #16 from Kristi <kkrueger@cuyahogalibrary.org> --- This would be really handy. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172365|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183837&action=edit Bug 38079: Add ability to choose sorting for holdings tables on details page This patch adds a new option 'default' to the sorting options in tables settings We need this so that we can add the option to define sorting, without setting a new default as the holdings table currently uses 'search_ordered' for a specific sorting when no sorting is provided To test: 1 - Add many items to a record, with various values 2 - View the holdings tab on details, note the order 3 - Apply patch, restart_all, reload 4 - Confirm order not changed 5 - Click 'Configure' 6 - Scroll to holdings table 7 - Change page size and save (noting sort is set to default) 8 - Reload and confirm the order has not changed 9 - Now change the sorting in the table settings 10 - Reload and confirm the sorting is saved -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 [Bug 38080] Sorting options for holdings table are incorrect -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased, simple conflict, checked that `yarn js:build` still works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42910 -- You are receiving this mail because: You are watching all bug changes.