[Bug 18584] New: Removing trailing-space from our codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Bug ID: 18584 Summary: Removing trailing-space from our codebase Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org This bug report is opened for didactic purpose. If you already contributed to Koha you must not contribute here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Removing trailing-space |Our legacy code contains |from our codebase |trailing-spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64236&action=edit Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64236|0 |1 is obsolete| | --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64237&action=edit Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64237|0 |1 is obsolete| | --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64238&action=edit Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Assignee|gmcharlt@gmail.com |koha-bugs@lists.koha-commun | |ity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lee Jamison from comment #3)
Created attachment 64238 [details] [review] Bug 18584: Fix trailing spaces in C4/Accounts.pm
Pushed to master, thanks Lee! Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and pushed to 2 stable releases (16.11 and 17.05) - congrats Lee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/joubu/ko | |ha-howto -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |dominic.pichette@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #7 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67095&action=edit Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67095|0 |1 is obsolete| | --- Comment #8 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67096&action=edit Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. Signed-off-by: Dominic Pichette <dominic@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67096|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67097&action=edit Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dominic.pichette@inlibro.co |koha-bugs@lists.koha-commun |m |ity.org Status|Passed QA |ASSIGNED --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Dominic Pichette from comment #7)
Created attachment 67095 [details] [review] Bug 18584 - removed white space in C4/Accounts.pm
Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279.
Pushed to master, Merci Dominic! Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #11 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67157&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #12 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67158&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #13 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67159&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #14 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67160&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #15 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67161&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Attachment #67157|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #16 from David Bourgault <david.bourgault@inlibro.com> --- Sorry, I attached to the wrong bug... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- 5400795 Bug 18584 - removed white space in C4/Accounts.pm Pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #19 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |carnold@dgiinc.com |ity.org | CC| |carnold@dgiinc.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #20 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Walking through the Koha-how-to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #21 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 79734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79734&action=edit Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79734|0 |1 is obsolete| | --- Comment #22 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 79743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79743&action=edit Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- Okay, I won't submit anything, as per comment #0, but I thought I would mention that "git stripspace" might be a useful command to read up on. That being said, C4/Matcher.pm has more to be found. However, to not take away a sense of accomplishment, I will sign off Cori's patch. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79743|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 79758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79758&action=edit Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug here is for learning, not about solving it all :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Cori Lynn Arnold` from comment #22)
Created attachment 79743 [details] [review]
Hi Cori, thanks for your patch. If you had followed the tutorial until the end you should have sent a signed off patch by yourself. I am going to mark this one as Passed QA as it has been signed off by Mark, but do not hesitate to give another go with a new patch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79758|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79811&action=edit Bug 18584: Removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79811|0 |1 is obsolete| | --- Comment #28 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 79953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79953&action=edit Bug 18584: Removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Great job on your first patch Cori! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|carnold@dgiinc.com |koha-bugs@lists.koha-commun | |ity.org Status|Pushed to Master |ASSIGNED --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81990&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81990|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82337&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Welcome aboard Thatcher, Signed Off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79953|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82337|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82347&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Well done! Welcome to the Koha developers! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Great job on your first patch Thatcher! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #37 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #38 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Resetting to New. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #40 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 85966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85966&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85966|0 |1 is obsolete| | --- Comment #41 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 85967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85967&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82347|0 |1 is obsolete| | Attachment #85967|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85968&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleymapley@catalyst.net.n |koha-bugs@lists.koha-commun |z |ity.org Status|Pushed to Master |ASSIGNED --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85968|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87746&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87746|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87750&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome work Thatcher, welcome aboard :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87750|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87775&action=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Resetting :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alexander Blanchard <alexander.blanchard@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.blanchard@ptfs-eu | |rope.com Assignee|koha-bugs@lists.koha-commun |alexander.blanchard@ptfs-eu |ity.org |rope.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Annisha <annisha@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #51 from Annisha <annisha@clamsnet.org> --- Created attachment 175456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175456&action=edit Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175456|0 |1 is obsolete| | --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175458&action=edit Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175458|0 |1 is obsolete| | --- Comment #53 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175610&action=edit Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #54 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Welcome, Annisha! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Welcome Annisha! To make sure you show up in the committers list as you'd like: At the moment your author line just has your first name. Would you like me to add your last name as well? (Failed QA here just means: I got a question!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexander.blanchard@ptfs-eu |annisha@clamsnet.org |rope.com | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #55)
Welcome Annisha!
To make sure you show up in the committers list as you'd like: At the moment your author line just has your first name. Would you like me to add your last name as well?
(Failed QA here just means: I got a question!)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #57 from Annisha Romney <annisha@clamsnet.org> --- (In reply to Katrin Fischer from comment #56)
(In reply to Katrin Fischer from comment #55)
Welcome Annisha!
To make sure you show up in the committers list as you'd like: At the moment your author line just has your first name. Would you like me to add your last name as well?
(Failed QA here just means: I got a question!)
Thanks Katrin! I should have double checked the standard that others use when I was working through this. I am happy to go with my full name, Annisha Romney (I just updated it in my account preferences here as well.) Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Annisha Romney from comment #57)
(In reply to Katrin Fischer from comment #56)
(In reply to Katrin Fischer from comment #55)
Welcome Annisha!
To make sure you show up in the committers list as you'd like: At the moment your author line just has your first name. Would you like me to add your last name as well?
(Failed QA here just means: I got a question!)
Thanks Katrin! I should have double checked the standard that others use when I was working through this. I am happy to go with my full name, Annisha Romney (I just updated it in my account preferences here as well.)
Thanks!
It's all good :) I'll update your author line accordingly before push. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alex Carver <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |alex@rcls.org Assignee|annisha@clamsnet.org |alex@rcls.org Status|RESOLVED |REOPENED --- Comment #60 from Alex Carver <alex@rcls.org> --- Reopening! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alex Carver <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #61 from Alex Carver <alex@rcls.org> --- Created attachment 189346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189346&action=edit Bug 18584: Remove trailing spaces in Barcodes.pm In legacy code, some trailing whitespaces have been left for training purposes. This patch removes the trailing whitespace at line 266 in C4/Barcodes.pm Test plan: 1. View C4/Barcodes.pm and note trailing whitespace at line 266. 2. Apply patch. 3. View C4/Barcodes.pm and note trailing whitespace has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alex Carver <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alex Carver <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189346|0 |1 is obsolete| | --- Comment #62 from Alex Carver <alex@rcls.org> --- Created attachment 189347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189347&action=edit Bug 18584: Remove trailing spaces in Barcodes.pm In legacy code, some trailing whitespaces have been left for training purposes. This patch removes the trailing whitespace at line 266 in C4/Barcodes.pm Test plan: 1. View C4/Barcodes.pm and note trailing whitespace at line 266. 2. Apply patch. 3. View C4/Barcodes.pm and note trailing whitespace has been removed. Signed-off-by: Acerock7 <alexcarver@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Alex Carver <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Signed-off-by: Acerock7 <alexcarver@gmail.com> do you want to appear with this username in the release note, or with your real name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #64 from Alex Carver [Acerock7] <alex@rcls.org> --- Hiya Jonathan. Full name is fine. I'll update my git username for any other patches. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189560&action=edit Bug 18584: Remove trailing spaces in Barcodes.pm In legacy code, some trailing whitespaces have been left for training purposes. This patch removes the trailing whitespace at line 266 in C4/Barcodes.pm Test plan: 1. View C4/Barcodes.pm and note trailing whitespace at line 266. 2. Apply patch. 3. View C4/Barcodes.pm and note trailing whitespace has been removed. Signed-off-by: Alex Carver <alexcarver@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed for 25.11.00, nice work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Resetting to NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Assignee|alex@rcls.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org