https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #2 from Hans Pålsson <hans.palsson@hkr.se> --- Just to make clear, this is to not allow patrons to make ILL requests from the OPAC. Patrons should still be able to see their ILL-loans "as usual" when logged in the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would be nice if we had both options - totally disable and only disable adding new. Maybe a multi-select pref or one with 3 possible values in the drop down? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syspref ILLOpacbackends can |Syspref ILLOpacbackends can |not be disbled |not be disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20639 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22305 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like I pointed this out on bug 20639 when the pref was introduced: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639#c14 And as a result bug 22305 was filed for this as another future enhancement. I will mark the older bug as as duplicate in this case, as I think this bug has more lively discussion/more content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but as the pref works as intended and described, this is not a major bug - it's more an enhancement request right now - the feature you want where the backends can only be enabled for the staff side doesn't exist right now. That doesn't mean I don't understand the need. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Can we invert this sys pref? Change old ILLOpacbackends to new HideILLOpacbackends HideILLOpacbackends: if empty: does/hides nothing if one/multiple backend: lists all backends except the one(s) listed if all backends: hide all backends For an upgrade script: Retrieve all currently installed backends (not sure how exactly) and retrieve old ILLOpacbackends value, then:

From the retrieved installed backends, get all that are not part of old ILLOpacbackends and set that to the new HideILLOpacbackends

Does the above respond to every use case for this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Hans Pålsson from comment #13)

it would be more logical to say what backends should be visible, since all are addons to Koha (mainly plugins).

Hi Hans! The workflow I'm proposing is: as soon as you install a backend, it's enabled and showing by default for both Staff and OPAC, as I believe this is likely the intent (and expectation) of most ILL backend installations (I may be wrong here, of course!). This change in the sys pref would provide the option of hiding in the OPAC any one, or more - or all - installed backends, an improvement over the current functionality that does not allow for hiding all the backends in the OPAC. Apologies if not clear enough! Any input or alternative suggestion is welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #14)

(In reply to Hans Pålsson from comment #13)

...

it would be more logical to say what backends should be visible, since all are addons to Koha (mainly plugins).

Hi Hans! The workflow I'm proposing is: as soon as you install a backend, it's enabled and showing by default for both Staff and OPAC, as I believe this is likely the intent (and expectation) of most ILL backend installations (I may be wrong here, of course!).

This change in the sys pref would provide the option of hiding in the OPAC any one, or more - or all - installed backends, an improvement over the current functionality that does not allow for hiding all the backends in the OPAC.

Apologies if not clear enough! Any input or alternative suggestion is welcome.

I believe it was done the currnet way for technical reasons. I am not sure if it's possible to detect all installed backends (probably that is possible), but it might be harder to trigger an update to pref at the time a backend is installed, without each backend implementing the update itself. I guess when this was added the intent was not to be disruptive/change current behaviour and not to enforce backend providers to change. Ideally we should display a list of installed backends in a list, so people just need to check/uncheck. Maybe an "all" or "always hide" option could work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lisette Scheer from comment #17)

If Bug 19605 makes backends pluggable would it be easier to generate a list of options?

Bug 19605 is updating the available_backends sub in Illrequest/Config.pm - among other things. That sub is designed to be the single source of truth for installed backends in a system, and that should be the case before and after bug 19605. (In reply to Katrin Fischer from comment #16)

Ideally we should display a list of installed backends in a list, so people just need to check/uncheck.

This would be ideal, I agree. Although looking at the code it seems it would be possible to have this working without each backend having to implement the update itself (which would be preferable I think). (In reply to Hans Pålsson from comment #0)

A syspref should not behave like this, if the field is left empty no backends should be available in the OPAC (?). An alternative solution is to set another syspref that enables/disables use of ILL in OPAC. Libraries that do not allow ordering of ILL from the OPAC must be able to hide this feature.

See bug 18203 (pushed to master). It's not the same as the ILLOpacbackends sys pref, but I believe it should help in satisfying the following requirement: "Libraries that do not allow ordering of ILL from the OPAC must be able to hide this feature." At least on a per borrower category basis. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #20 from Hans Pålsson <hans.palsson@hkr.se> --- Setting this as resolved because 18203 solved the issue. Thanks all again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.