https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167718&action=edit Bug 37091: Correct op parameter in systempreferences.pl To test: 1. Go to Administration > System Preferences > Local Use 2. Attempt to delete a local system preference --> The confirmation page displays a blank name and value 3. Click "Yes, delete" --> The system preference is still there 4. Apply patch, restart_all, and reload page 5. Attempt to delete the system preference again --> The confirmation page displays correct information 6. Click "Yes, delete" --> The system preference is deleted successfully -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch, I get an error trace when trying to delete a local use system preference (either an existing one or a new one): Can't call method "delete" on an undefined value at /kohadevbox/koha/C4/Context.pm line 436 ..... 2. After the patch, and after the local use system preference is deleted, the body of the page is blank, rather than listing the remaining local use system preferences. The system preference categories are listed on the left, the breadrumb is just "Administration", Search system preferences is selected in the header, and the browser page title is "Local use system preferences > Administration > Koha". I'm not sure what it did before the CSRF patch, and whether this needs fixing as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #4)

The proposed patch removes "cud-" prefix in .pl whereas it is a delete operation. The fix should be to add the "cud-" prefix in templ

Please don#t hesitate to set FQA - it helps to alert and keep things moving. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167764|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 167964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167964&action=edit Bug 37091: Correct op parameter in systempreferences.pl To test: 1. Go to Administration > System Preferences > Local Use 2. Attempt to delete a local system preference --> The confirmation page displays a blank name and value 3. Click "Yes, delete" --> The system preference is still there 4. Apply patch, restart_all, and reload page 5. Attempt to delete the system preference again --> The confirmation page displays correct information 6. Click "Yes, delete" --> The system preference is deleted successfully Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #6)

Ah sorry, I didn't want to send that. I started to write it and noticed I was wrong... so please ignore. I will probably pass QA in a few minutes :)

All good then, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- No changes required to the manual. There are no changes to the page - it is fixing things so that they now work as they should! -- You are receiving this mail because: You are watching all bug changes.