[Bug 37129] New: Patron attributes linked to an authorized value don't show a select menu in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Bug ID: 37129 Summary: Patron attributes linked to an authorized value don't show a select menu in batch modification Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Blocks: 36192 If you have a patron attribute linked to an authorized value (like we do by default for "Show barcode on the summary screen items listings") then in patron batch modification rather than getting a select menu to choose an authorized value to change to, you just get a text input, thanks to a stray cud-. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167885&action=edit Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167885|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167894&action=edit Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Phil for adding a patch so quickly to fix this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167894|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167941&action=edit Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Patch complexity|--- |Trivial patch CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the quick fix! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Full CSRF not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Text to go in the| |This fixes the patron batch release notes| |modification tool so that | |patron attributes linked to | |an authorized value now | |show the dropdown list of | |values. (This is related to | |the CSRF changes added in | |Koha 24.05 to improve form | |security.) Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- No changes required to the manual - the screenshots for the batch patron modification form are current. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org