[Bug 20193] New: Label export displaying on never-ending webpage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Bug ID: 20193 Summary: Label export displaying on never-ending webpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org When trying to export a label batch, the pop up frame to display export options is not being correctly created. Instead the export information is at the bottom of a never-ending page. (Scrolling never reaches it). To reproduce: Go to Manage Label batches (label-manage.pl) and/or edit a batch (label-edit-batch.pl) and try to export. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |oleonard@myacpl.org |u | Depends on| |12904 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Label export displaying on |Path to Greybox CSS broken |never-ending webpage |after Bug 120904 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Path to Greybox CSS broken |Path to Greybox CSS broken |after Bug 120904 |after Bug 12904 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71608&action=edit Bug 20193: Path to Greybox CSS broken after Bug 12904 Bug 12904 changed the way CSS and JS assets should be linked, but the Greybox CSS path wasn't changed in the process. This patch adds the required VERSION template variable to greybox.inc. To test, apply the patch and test usage of Greybox in the staff client. For instance: - Go to Tools -> Labels -> Manage -> Label batches - Select a batch for export and click the 'Export selected' button - A Greybox modal should be triggered, and the export process should proceed correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 [Bug 20160] Sort translated languages by code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71608|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71621&action=edit Bug 20193: Path to Greybox CSS broken after Bug 12904 Bug 12904 changed the way CSS and JS assets should be linked, but the Greybox CSS path wasn't changed in the process. This patch adds the required VERSION template variable to greybox.inc. To test, apply the patch and test usage of Greybox in the staff client. For instance: - Go to Tools -> Labels -> Manage -> Label batches - Select a batch for export and click the 'Export selected' button - A Greybox modal should be triggered, and the export process should proceed correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Another test case is the Translate into other languages step in bug 20160. If you do not apply this, the popup failed to popup. It was quite frustrating. Thank you for this patch, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Also, noticed that the patch that made it into master (the apache conf tweak) was [0-9][0-9]... instead of just (.*), so part of the problems may have been the fix was partially broken by use of a bad regular expression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Bug 20193 depends on bug 12904, which changed state. Bug 12904 Summary: Force browser to load new javascript files after upgrade https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71621|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71698&action=edit Bug 20193: Path to Greybox CSS broken after Bug 12904 Bug 12904 changed the way CSS and JS assets should be linked, but the Greybox CSS path wasn't changed in the process. This patch adds the required VERSION template variable to greybox.inc. To test, apply the patch and test usage of Greybox in the staff client. For instance: - Go to Tools -> Labels -> Manage -> Label batches - Select a batch for export and click the 'Export selected' button - A Greybox modal should be triggered, and the export process should proceed correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org