[Bug 20221] New: Fix for JavaScript error during checkout or holds patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Bug ID: 20221 Summary: Fix for JavaScript error during checkout or holds patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19641 If you submit a patron name to the checkout form it will trigger a JavaScript error in the console because there is JS embedded in an include, circ-patron-search-results.inc. This JS should be moved so that it is included in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix for JavaScript error |Fix for JavaScript error |during checkout or holds |during checkout patron |patron search |search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71694&action=edit Bug 20221 - Fix for JavaScript error during checkout patron search This patch fixes a bug caused by the changes in Bug 19641. JavaScript embedded in circ-patron-search-results.inc executes before jQuery is loaded. This patch adds a separate javascript file which can be included both in circulation.tt and request.tt since both use the same include. To test, apply the patch and submit a patron name in the check out form. On the page of search results, clicking a table row should work the same as clicking the patron name link. Perform the same test during the hold process: Locate and place a hold on a title. In the patron search form, submit a patron name and test the behavior of the search results screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org